Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rgbaArray type definition to a tuple #1590

Closed
acashjos opened this issue May 18, 2021 · 1 comment
Closed

Change rgbaArray type definition to a tuple #1590

acashjos opened this issue May 18, 2021 · 1 comment

Comments

@acashjos
Copy link

Feature Request

More of a tiny typedef improvement suggestion.
I accidentally imported rgbaArray from index.d.ts of this module today, and noticed that its a ReadonlyArray<number>.
This type can have n number of items, while I'd expect an rgba type to have only 4 number items.

Code sample

Changing
export type rgbaArray = ReadonlyArray<number>;
to
export type rgbaArray =Readonly<[r:number, g: number, b: number, a: number]>;

@WoLewicki
Copy link
Member

This type has been removed as a part of #1726, so I believe this is not a problem anymore. Thanks for your contribution though! I will close this issue. Feel free to comment here if something is wrong and we can always reopen it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants