Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Expected closing tag </head> to match opening tag <meta> #1760

Closed
scshiv29-dev opened this issue May 1, 2022 · 2 comments
Closed

Error: Expected closing tag </head> to match opening tag <meta> #1760

scshiv29-dev opened this issue May 1, 2022 · 2 comments

Comments

@scshiv29-dev
Copy link

NB Never post screenshots of code. Post copy paste-able code if you include any.
Ignoring this will likely lead to direct closing of the issue.
Please respect the time and energy of open source maintainers.

Bug

Error: Expected closing tag to match opening tag If this is valid SVG, it's probably a bug. Please raise an issue

Environment info

Run react-native info in your terminal and copy the results here. Also, include the precise version number of this library that you are using in the project

React native info output:

System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
    Memory: 6.39 GB / 15.95 GB
  Binaries:
    Node: 16.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.11 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.3 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK:
      API Levels: 26, 27, 29, 30, 31
      Build Tools: 27.0.3, 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0, 31.0.0, 33.0.0
      System Images: android-29 | Google APIs Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
    Windows SDK: Not Found
  IDEs:
    Android Studio: Version  4.1.0.0 AI-201.8743.12.41.6953283
    Visual Studio: 16.10.31424.327 (Visual Studio Community 2019)
  Languages:
    Java: 15.0.2
    Python: 3.10.2
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.68.1 => 0.68.1
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 12.3.0

Steps To Reproduce

  1. git clone https://github.com/scshiv29-dev/notiftrybug
  2. cd rnsvg-bug-repro
  3. yarn
  4. yarn ios
  5. yarn android
  6. ...

Describe what you expected to happen:

1.expected the svg to show
@gabimoncha gabimoncha mentioned this issue May 12, 2022
Closed
@gabimoncha
Copy link

It's because the error handling features was never included in the release

@PiotrWszolek PiotrWszolek mentioned this issue Jun 22, 2023
Merged
4 tasks
@WoLewicki
Copy link
Member

Closing since #2071 has been merged and it provides better handling of parsing error.

@quangkcao quangkcao mentioned this issue Dec 19, 2023
Merged
4 tasks
WoLewicki pushed a commit that referenced this issue Jan 3, 2024
@quangkcao
fix(SvgCssUri): support rendering fallback instead of crashing the ap…
ff18553 
…p when loading invalid content from remote svg file (#2196)

This crash issue still happening for SvgCssUri component
#1760

Apply similar fix #2071
specifically for SvgCSSUri component to prevent crashes due to invalid svg content

What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
-> When loading invalid svg uri with SvgCSSUri, the app crashes crashes. For example the content returning html content instead of valid svg content.

How did you implement the solution?
-> Passing the fallback prop to SvgCss where will be render when error being captured

What areas of the library does it impact?
SvgCss and SvgUriCss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WoLewicki @gabimoncha @scshiv29-dev