Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Support for transform prop #1835

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Web: Support for transform prop #1835

merged 2 commits into from
Oct 18, 2022

Conversation

RobertSasak
Copy link
Contributor

@RobertSasak RobertSasak commented Aug 15, 2022 •
edited
Loading

Summary

Transform prop is ignored on web. This PR stringify transform props so it is compatible with web SVG. It is an extension of #1824

Compatibility

OS Implemented
iOS no change
Android no change
Web ✅

Checklist

  • [X ] I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@RobertSasak @WoLewicki
Update src/ReactNativeSVG.web.ts
4a3f7e9 
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
@WoLewicki WoLewicki merged commit dadf0c9 into software-mansion:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertSasak @WoLewicki