Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include proguard config #1842

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Conversation

heroic
Copy link
Contributor

@heroic heroic commented Aug 18, 2022

Summary

This will remove the requirement for people to add the proguard configs themselves. A lot of people first release to production with proguard and then realize why the app crashes. This will solve such issues.

This uses android's consumer proguard setting to enable specific proguard config.

Test Plan

Example app works. All tests pass.

What's required for testing (prerequisites)?

Example app works. All tests pass.

What are the steps to reproduce (after prerequisites)?

Proguard enabled release should work without any manual edits to proguard file in the app.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

This will remove the requirement for people to add the proguard configs themselves
They are no longer needed
@heroic
Copy link
Contributor Author

heroic commented Aug 18, 2022

@msand @WoLewicki, can you also release with this for 12.*?

@WoLewicki
Copy link
Member

@heroic thanks for your contribution! As for releasing it for 12.*, I think it is no longer necessary since 13.* should be stable right now. Or am I missing something?

@WoLewicki WoLewicki merged commit 1637580 into software-mansion:main Jan 3, 2023
@heroic heroic deleted the feature/proguard branch January 3, 2023 17:50
@heroic heroic restored the feature/proguard branch January 3, 2023 17:50
@heroic
Copy link
Contributor Author

heroic commented Jan 3, 2023

@heroic thanks for your contribution! As for releasing it for 12.*, I think it is no longer necessary since 13.* should be stable right now. Or am I missing something?

not sure what's the status of expo with 13.*

@WoLewicki
Copy link
Member

Expo SDK 47 features version 13.4.0 of the library so it should be ok.

@heroic heroic deleted the feature/proguard branch January 19, 2023 16:59
hyochan referenced this pull request in hyochan/dooboo-ui Mar 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://github.com/react-native-community/react-native-svg)
| [`13.4.0` ->
`13.8.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.8.0)
|
[![age](https://badges.renovateapi.com/packages/npm/react-native-svg/13.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/react-native-svg/13.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/react-native-svg/13.8.0/compatibility-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/react-native-svg/13.8.0/confidence-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg</summary>

###
[`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0)

Minor release bringing Fabric support to RN v0.71 🎉

#### What's Changed

- feat: update FabricExample to 0.71.0-rc.6 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962)
- chore: ensure consistent use of `import type` by
[@&#8203;tido64](https://github.com/tido64) in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)
- chore: change fabric flag by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979)

#### New Contributors

- [@&#8203;tido64](https://github.com/tido64) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)

**Full Changelog**:
software-mansion/react-native-svg@v13.7.0...v13.8.0

###
[`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0)

#### What's Changed

- Fix windows build issues by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923)
- fix: fill/stroke setters and implement currentColor on Windows by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928)
- refactor: remove circular dependency by
[@&#8203;Fasteel](https://github.com/Fasteel) in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- Include proguard config by
[@&#8203;heroic](https://github.com/heroic) in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- fix: accept comas in viewbox by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952)
- Fix nested SVGs in iOS
[#&#8203;1437](https://github.com/react-native-community/react-native-svg/issues/1437)
by [@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948)
- fix: restore black as a default color for svgs by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947)
- feat(windows): add clipPath and touch events by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933)
- fix: Call onLoad prop in SvgCssUri by
[@&#8203;mantasio](https://github.com/mantasio) in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)
- feat(windows): add example app by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937)

#### New Contributors

- [@&#8203;Fasteel](https://github.com/Fasteel) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- [@&#8203;heroic](https://github.com/heroic) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- [@&#8203;mantasio](https://github.com/mantasio) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)

**Full Changelog**:
software-mansion/react-native-svg@v13.6.0...v13.7.0

###
[`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0)

Minor release fixing some bugs and introducing compatibility with Static
View Configs, Bridgeless Mode and maybe some more updated on `Fabric`.

#### What's Changed

- chore: remove formatting from blame by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905)
- feat: use codegenNativeComponent to import native views by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847)
- chore: add react-native-svg banner to README by
[@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)
- fix: make svg compile on older versions by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907)
- chore: update RN versions to 0.70.5 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910)
- fix: update supported RN version to 0.64 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912)
- chore: align examples by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914)
- chore: bump supported RN version for Fabric by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913)
- feat: use transform parsing code from rn core by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918)

#### New Contributors

- [@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) made
their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)

**Full Changelog**:
software-mansion/react-native-svg@v13.5.0...v13.6.0

###
[`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/dooboolab/dooboo-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
hyochan referenced this pull request in hyochan/dooboo-ui Apr 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://github.com/react-native-community/react-native-svg)
| [`13.4.0` ->
`13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0)
|
[![age](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/compatibility-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/confidence-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg</summary>

###
[`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0)

Minor release introducing `marker` support for elements on `Android`,
adding accessibility props needed also for e2e testing and fixing many
issues in the repo 🎉 Thanks to all contributors!

#### What's Changed

- chore: update Example to newest react-native version by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999)
- Upgrade rn-builder-bob to enable tree-shaking in rn-web by
[@&#8203;merrywhether](https://github.com/merrywhether) in
[https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993)
- add accessibility and testId props and virtual nodes to support e2e
tests tools by [@&#8203;toter3](https://github.com/toter3) in
[https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001)
- fix onLayout by [@&#8203;toter3](https://github.com/toter3) in
[https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998)
- Don't set `self.opaque = false` on macOS by
[@&#8203;hsjoberg](https://github.com/hsjoberg) in
[https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008)
- Fix SVG parsing when the closing tags include whitespace by
[@&#8203;MichalSzorad](https://github.com/MichalSzorad) in
[https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012)
- chore: set library namespace in build script by
[@&#8203;kkafar](https://github.com/kkafar) in
[https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005)
- fix: make image props extend CommonPathProps by
[@&#8203;andev240](https://github.com/andev240) in
[https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007)
- fix: mask render on android by
[@&#8203;Aflexon](https://github.com/Aflexon) in
[https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981)
- fix: remove unnecessary methods provided by superclasses for
accessibility by [@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013)
- chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982)
- chore(deps): bump
[@&#8203;xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6
to 0.7.9 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004)
- fix
[#&#8203;1592](https://github.com/react-native-community/react-native-svg/issues/1592)
: add marker support on Rect, Line, Ellipse, Circle and Group by
[@&#8203;mlecoq](https://github.com/mlecoq) in
[https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594)
- fix: scale path markers so they match ios by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018)
- fix: read svg file on android by
[@&#8203;vicke4](https://github.com/vicke4) in
[https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016)

#### New Contributors

- [@&#8203;merrywhether](https://github.com/merrywhether) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993)
- [@&#8203;toter3](https://github.com/toter3) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001)
- [@&#8203;hsjoberg](https://github.com/hsjoberg) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008)
- [@&#8203;MichalSzorad](https://github.com/MichalSzorad) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012)
- [@&#8203;kkafar](https://github.com/kkafar) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005)
- [@&#8203;andev240](https://github.com/andev240) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007)
- [@&#8203;Aflexon](https://github.com/Aflexon) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981)
- [@&#8203;mlecoq](https://github.com/mlecoq) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594)
- [@&#8203;vicke4](https://github.com/vicke4) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016)

**Full Changelog**:
software-mansion/react-native-svg@v13.8.0...v13.9.0

###
[`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0)

Minor release bringing Fabric support to RN v0.71 🎉

#### What's Changed

- feat: update FabricExample to 0.71.0-rc.6 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962)
- chore: ensure consistent use of `import type` by
[@&#8203;tido64](https://github.com/tido64) in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)
- chore: change fabric flag by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979)

#### New Contributors

- [@&#8203;tido64](https://github.com/tido64) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)

**Full Changelog**:
software-mansion/react-native-svg@v13.7.0...v13.8.0

###
[`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0)

#### What's Changed

- Fix windows build issues by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923)
- fix: fill/stroke setters and implement currentColor on Windows by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928)
- refactor: remove circular dependency by
[@&#8203;Fasteel](https://github.com/Fasteel) in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- Include proguard config by
[@&#8203;heroic](https://github.com/heroic) in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- fix: accept comas in viewbox by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952)
- Fix nested SVGs in iOS
[#&#8203;1437](https://github.com/react-native-community/react-native-svg/issues/1437)
by [@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948)
- fix: restore black as a default color for svgs by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947)
- feat(windows): add clipPath and touch events by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933)
- fix: Call onLoad prop in SvgCssUri by
[@&#8203;mantasio](https://github.com/mantasio) in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)
- feat(windows): add example app by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937)

#### New Contributors

- [@&#8203;Fasteel](https://github.com/Fasteel) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- [@&#8203;heroic](https://github.com/heroic) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- [@&#8203;mantasio](https://github.com/mantasio) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)

**Full Changelog**:
software-mansion/react-native-svg@v13.6.0...v13.7.0

###
[`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0)

Minor release fixing some bugs and introducing compatibility with Static
View Configs, Bridgeless Mode and maybe some more updated on `Fabric`.

#### What's Changed

- chore: remove formatting from blame by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905)
- feat: use codegenNativeComponent to import native views by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847)
- chore: add react-native-svg banner to README by
[@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)
- fix: make svg compile on older versions by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907)
- chore: update RN versions to 0.70.5 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910)
- fix: update supported RN version to 0.64 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912)
- chore: align examples by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914)
- chore: bump supported RN version for Fabric by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913)
- feat: use transform parsing code from rn core by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918)

#### New Contributors

- [@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) made
their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)

**Full Changelog**:
software-mansion/react-native-svg@v13.5.0...v13.6.0

###
[`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
hyochan referenced this pull request in hyochan/dooboo-ui Jun 20, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://github.com/react-native-community/react-native-svg)
| [`13.4.0` ->
`13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0)
|
[![age](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/compatibility-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/confidence-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg</summary>

###
[`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0)

Minor release introducing `marker` support for elements on `Android`,
adding accessibility props needed also for e2e testing and fixing many
issues in the repo 🎉 Thanks to all contributors!

#### What's Changed

- chore: update Example to newest react-native version by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999)
- Upgrade rn-builder-bob to enable tree-shaking in rn-web by
[@&#8203;merrywhether](https://github.com/merrywhether) in
[https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993)
- add accessibility and testId props and virtual nodes to support e2e
tests tools by [@&#8203;toter3](https://github.com/toter3) in
[https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001)
- fix onLayout by [@&#8203;toter3](https://github.com/toter3) in
[https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998)
- Don't set `self.opaque = false` on macOS by
[@&#8203;hsjoberg](https://github.com/hsjoberg) in
[https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008)
- Fix SVG parsing when the closing tags include whitespace by
[@&#8203;MichalSzorad](https://github.com/MichalSzorad) in
[https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012)
- chore: set library namespace in build script by
[@&#8203;kkafar](https://github.com/kkafar) in
[https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005)
- fix: make image props extend CommonPathProps by
[@&#8203;andev240](https://github.com/andev240) in
[https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007)
- fix: mask render on android by
[@&#8203;Aflexon](https://github.com/Aflexon) in
[https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981)
- fix: remove unnecessary methods provided by superclasses for
accessibility by [@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013)
- chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982)
- chore(deps): bump
[@&#8203;xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6
to 0.7.9 by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004)
- fix
[#&#8203;1592](https://github.com/react-native-community/react-native-svg/issues/1592)
: add marker support on Rect, Line, Ellipse, Circle and Group by
[@&#8203;mlecoq](https://github.com/mlecoq) in
[https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594)
- fix: scale path markers so they match ios by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018)
- fix: read svg file on android by
[@&#8203;vicke4](https://github.com/vicke4) in
[https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016)

#### New Contributors

- [@&#8203;merrywhether](https://github.com/merrywhether) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993)
- [@&#8203;toter3](https://github.com/toter3) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001)
- [@&#8203;hsjoberg](https://github.com/hsjoberg) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008)
- [@&#8203;MichalSzorad](https://github.com/MichalSzorad) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012)
- [@&#8203;kkafar](https://github.com/kkafar) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005)
- [@&#8203;andev240](https://github.com/andev240) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007)
- [@&#8203;Aflexon](https://github.com/Aflexon) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981)
- [@&#8203;mlecoq](https://github.com/mlecoq) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594)
- [@&#8203;vicke4](https://github.com/vicke4) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016)

**Full Changelog**:
software-mansion/react-native-svg@v13.8.0...v13.9.0

###
[`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0)

Minor release bringing Fabric support to RN v0.71 🎉

#### What's Changed

- feat: update FabricExample to 0.71.0-rc.6 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962)
- chore: ensure consistent use of `import type` by
[@&#8203;tido64](https://github.com/tido64) in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)
- chore: change fabric flag by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979)

#### New Contributors

- [@&#8203;tido64](https://github.com/tido64) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971)

**Full Changelog**:
software-mansion/react-native-svg@v13.7.0...v13.8.0

###
[`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0)

#### What's Changed

- Fix windows build issues by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923)
- fix: fill/stroke setters and implement currentColor on Windows by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928)
- refactor: remove circular dependency by
[@&#8203;Fasteel](https://github.com/Fasteel) in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- Include proguard config by
[@&#8203;heroic](https://github.com/heroic) in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- fix: accept comas in viewbox by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952)
- Fix nested SVGs in iOS
[#&#8203;1437](https://github.com/react-native-community/react-native-svg/issues/1437)
by [@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948)
- fix: restore black as a default color for svgs by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947)
- feat(windows): add clipPath and touch events by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933)
- fix: Call onLoad prop in SvgCssUri by
[@&#8203;mantasio](https://github.com/mantasio) in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)
- feat(windows): add example app by
[@&#8203;marlenecota](https://github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937)

#### New Contributors

- [@&#8203;Fasteel](https://github.com/Fasteel) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929)
- [@&#8203;heroic](https://github.com/heroic) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842)
- [@&#8203;mantasio](https://github.com/mantasio) made their first
contribution in
[https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927)

**Full Changelog**:
software-mansion/react-native-svg@v13.6.0...v13.7.0

###
[`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0)

Minor release fixing some bugs and introducing compatibility with Static
View Configs, Bridgeless Mode and maybe some more updated on `Fabric`.

#### What's Changed

- chore: remove formatting from blame by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905)
- feat: use codegenNativeComponent to import native views by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847)
- chore: add react-native-svg banner to README by
[@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)
- fix: make svg compile on older versions by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907)
- chore: update RN versions to 0.70.5 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910)
- fix: update supported RN version to 0.64 by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912)
- chore: align examples by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914)
- chore: bump supported RN version for Fabric by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913)
- feat: use transform parsing code from rn core by
[@&#8203;WoLewicki](https://github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918)

#### New Contributors

- [@&#8203;kacperkapusciak](https://github.com/kacperkapusciak) made
their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909)

**Full Changelog**:
software-mansion/react-native-svg@v13.5.0...v13.6.0

###
[`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

[Compare
Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/dooboolab-community/dooboo-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants