fix: [types] allow Image "href" & "xlinkHref" to be strings #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow 'string' type for
hrefandxlinkHrefprops inImagecomponent.Logic in the component allows passing 'string' values to the
Image.resolveAssetSourceby checking for its type, so it would be nice to reflect it on the properties types as well.Test Plan
Purely typing changes, so you can see at least how I was able to remove now-useless
@ts-expect-errors in the example app.What's required for testing (prerequisites)?
not applicable
What are the steps to reproduce (after prerequisites)?
not applicable
Compatibility
Checklist
README.md__tests__folder