Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle null passed to matrix and tintColor #1904

Merged
merged 1 commit into from
Nov 2, 2022
Merged

fix: handle null passed to matrix and tintColor #1904

merged 1 commit into from
Nov 2, 2022

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Nov 2, 2022 •
edited
Loading

PR adding handling of null values passed to matrix and tintColor props on Android. It should not happen from normal render method, but can still be passed with Animated or Reanimated through native updates or setNativeProps. Should fix #1900, #1899.

@WoLewicki WoLewicki linked an issue Nov 2, 2022 that may be closed by this pull request
Android crash after upgrading from 13.2.0 #1899
Closed
This was referenced Nov 2, 2022
Closed
Closed
@WoLewicki WoLewicki merged commit f2130ad into main Nov 2, 2022
@WoLewicki WoLewicki deleted the @wolewicki/handle-more-nulls-on-Android branch November 2, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] NPE in VirtualView/PropHelper Android crash after upgrading from 13.2.0
1 participant
@WoLewicki