Upgrade rn-builder-bob to enable tree-shaking in rn-web #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2023
merrywhether
force-pushed
the
upgrade-bob
branch
from
5ea5cd0
to
5dfa9b2
Compare
merrywhether
commented
Feb 25, 2023
Comment on lines
-73
to
-75
| "@babel/core": "^7.18.2", | ||
| "@babel/plugin-syntax-flow": "^7.17.12", | ||
| "@babel/plugin-transform-react-jsx": "^7.17.12", |
There was a problem hiding this comment.
These are provided by RN/metro already.
satya164
pushed a commit
to callstack/react-native-builder-bob
that referenced
this pull request
Feb 26, 2023
The`@babel/plugin-proposal-class-properties` no longer needs to be
explicitly added, as it is now incorporated into `@babel/preset-env`.
You can see this in a freshly generated RN library by adding `debug:
true` to this default configuration:
```
% yarn bob build
yarn run v1.22.19
$ .../rnlib/node_modules/.bin/bob build
ℹ Building target commonjs
ℹ Cleaning up previous build at lib/commonjs
ℹ Compiling 1 files in src with babel
@babel/preset-env: `DEBUG` option
Using targets:
{
"chrome": "108",
"edge": "108",
"firefox": "108",
"ios": "15.6",
"node": "16",
"safari": "15.6",
"samsung": "19"
}
Using modules transform: commonjs
Using plugins:
proposal-class-static-block { ios, node < 16.11, safari }
proposal-private-property-in-object { node < 16.9 }
syntax-class-properties <----
syntax-numeric-separator
syntax-nullish-coalescing-operator
proposal-optional-chaining { node < 16.9 }
syntax-json-strings
syntax-optional-catch-binding
transform-parameters { ios, safari }
syntax-async-generators
syntax-object-rest-spread
proposal-export-namespace-from { ios, safari }
transform-modules-commonjs
proposal-dynamic-import
...
```
Removing this duplicate entry ensures the optimal application of
transforms within the preset-env space. This was discovered while
attempting to update `react-native-svg`, which has a pathologic case in
their `Symbol.tsx` that causes a babel parser error that is resolved
when this entry is removed:
```
Error: .../react-native-svg/src/elements/Symbol.tsx: We don't know what to do with this node type. We were previously a Statement but we can't fit in here?
at NodePath.insertBefore (.../react-native-svg/node_modules/@babel/traverse/lib/path/modification.js:57:11)
...
at async.call.result.err.err (.../react-native-svg/node_modules/gensync/index.js:223:11) {
code: 'BABEL_TRANSFORM_ERROR'
```
### Test plan
I reproduced the minimal problem space at
https://github.com/merrywhether/rnlib, and also verified that this
allows `react-native-svg` to build against
`react-native-builder-bob@0.20.0` (after upgrading it from
`@react-native-community/bob@0.9.7`).
Closes #154.
Unblocks software-mansion/react-native-svg#1993.
merrywhether
force-pushed
the
upgrade-bob
branch
from
5dfa9b2
to
b3913ff
Compare
merrywhether
force-pushed
the
upgrade-bob
branch
from
94a5659
to
e4d4c8e
Compare
merrywhether
force-pushed
the
upgrade-bob
branch
from
e4d4c8e
to
769393d
Compare
|
Looked into the failing builds and realized I'd pulled from our private registry at first. Regenerated |
|
@merrywhether Could you also bump the version of node used in the JS build workflow? Based on the failed build it should be 16 here: and it the step name.Ok I edited the PR and all checks pass now 🚀 |
WoLewicki
approved these changes
Mar 21, 2023
Thanks for bumping that. Sorry I was a little slow on the follow-up responsiveness here but happy that we got it merged. |
|
Yeah no problem 😅 |
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Apr 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://github.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://github.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://github.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://github.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://github.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://github.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://github.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://github.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://github.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://github.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://github.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://github.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://github.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://github.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://github.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://github.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://github.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://github.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://github.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://github.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://github.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://github.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://github.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://github.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://github.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://github.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://github.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
hyochan
referenced
this pull request
in hyochan/dooboo-ui
Jun 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://github.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://github.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://github.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://github.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://github.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://github.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://github.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://github.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://github.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://github.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://github.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://github.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://github.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://github.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://github.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://github.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://github.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://github.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://github.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://github.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://github.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://github.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://github.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://github.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://github.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://github.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://github.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
.web.jspath in this library currently breaks tree-shaking in web projects, causing them to import the entire ~250kb of react-native-web regardless of their other configuration:This is because the module build artifacts like
lib/module/ReactNativeSVG.web.jsare in pure ES5 and not ES5+ESM (es5 but preserving import/export statements).Updating to the latest version of
rn-builder-bob(which had a prerequisite fix in callstack/react-native-builder-bob#363 for this library) fixes this, generating the proper ES5+ESM output for the module build (while leaving the commonjs build in pure ES5 withrequire):Test Plan
This change should only affect the build output and not anything in the native layers.
Verified against simulators:
What's required for testing (prerequisites)?
n/a
What are the steps to reproduce (after prerequisites)?
Generally navigate around and see that everything still works.
Compatibility
Checklist
README.md__tests__folder