-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add accessibility and testId props and virtual nodes to support e2e tests tools #2001
add accessibility and testId props and virtual nodes to support e2e tests tools #2001
Conversation
@WoLewicki yes this is almost identical, I actually didn't see this one, i saw another PR Gal opened from the company's user i think, and it was missing some stuff. anyway since it wasn't merged and a lot of versions changed since, maybe it'll be easier to merge this one. |
In general, it's not good to merge duplicate PRs, as it can be considered unfair to the original author. The problem is that I asked for a rebase to the latest main more than half a year ago, and @galkahana doesn't seem to have responded at all. Therefore, I will merge this PR, but add a note that @galkahana is the original author. |
will do, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments about the code, but other than that, it seems just fine! I will change those in another PR. Thanks for your contribution!
[self invalidate]; | ||
} | ||
|
||
- (void)setAccessible:(BOOL)accessible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about accessibilityLabel
prop?
@@ -111,6 +117,18 @@ export default function extractProps( | |||
extracted.name = String(id); | |||
} | |||
|
|||
if (testID) { | |||
extracted.testID = String(testID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the types for those are already string/boolean, I think we don't need to do String(x)
or Boolean(x)
.
thanks @toter3 and @WoLewicki !! |
and @galkahana :) |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [![age](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/compatibility-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/confidence-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://github.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://github.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://github.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://github.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://github.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://github.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://github.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://github.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://github.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://github.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://github.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://github.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://github.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://github.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://github.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://github.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://github.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://github.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://github.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://github.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://github.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://github.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://github.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://github.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://github.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://github.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://github.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`13.4.0` -> `13.9.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.4.0/13.9.0) | [![age](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/compatibility-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/react-native-svg/13.9.0/confidence-slim/13.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg</summary> ### [`v13.9.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.9.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.8.0...v13.9.0) Minor release introducing `marker` support for elements on `Android`, adding accessibility props needed also for e2e testing and fixing many issues in the repo 🎉 Thanks to all contributors! #### What's Changed - chore: update Example to newest react-native version by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1999](https://github.com/software-mansion/react-native-svg/pull/1999) - Upgrade rn-builder-bob to enable tree-shaking in rn-web by [@​merrywhether](https://github.com/merrywhether) in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - add accessibility and testId props and virtual nodes to support e2e tests tools by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - fix onLayout by [@​toter3](https://github.com/toter3) in [https://github.com/software-mansion/react-native-svg/pull/1998](https://github.com/software-mansion/react-native-svg/pull/1998) - Don't set `self.opaque = false` on macOS by [@​hsjoberg](https://github.com/hsjoberg) in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - Fix SVG parsing when the closing tags include whitespace by [@​MichalSzorad](https://github.com/MichalSzorad) in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - chore: set library namespace in build script by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - fix: make image props extend CommonPathProps by [@​andev240](https://github.com/andev240) in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - fix: mask render on android by [@​Aflexon](https://github.com/Aflexon) in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - fix: remove unnecessary methods provided by superclasses for accessibility by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2013](https://github.com/software-mansion/react-native-svg/pull/2013) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/1982](https://github.com/software-mansion/react-native-svg/pull/1982) - chore(deps): bump [@​xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.6 to 0.7.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2004](https://github.com/software-mansion/react-native-svg/pull/2004) - fix [#​1592](https://github.com/react-native-community/react-native-svg/issues/1592) : add marker support on Rect, Line, Ellipse, Circle and Group by [@​mlecoq](https://github.com/mlecoq) in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - fix: scale path markers so they match ios by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2018](https://github.com/software-mansion/react-native-svg/pull/2018) - fix: read svg file on android by [@​vicke4](https://github.com/vicke4) in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) #### New Contributors - [@​merrywhether](https://github.com/merrywhether) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1993](https://github.com/software-mansion/react-native-svg/pull/1993) - [@​toter3](https://github.com/toter3) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2001](https://github.com/software-mansion/react-native-svg/pull/2001) - [@​hsjoberg](https://github.com/hsjoberg) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2008](https://github.com/software-mansion/react-native-svg/pull/2008) - [@​MichalSzorad](https://github.com/MichalSzorad) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2012](https://github.com/software-mansion/react-native-svg/pull/2012) - [@​kkafar](https://github.com/kkafar) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2005](https://github.com/software-mansion/react-native-svg/pull/2005) - [@​andev240](https://github.com/andev240) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2007](https://github.com/software-mansion/react-native-svg/pull/2007) - [@​Aflexon](https://github.com/Aflexon) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1981](https://github.com/software-mansion/react-native-svg/pull/1981) - [@​mlecoq](https://github.com/mlecoq) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1594](https://github.com/software-mansion/react-native-svg/pull/1594) - [@​vicke4](https://github.com/vicke4) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2016](https://github.com/software-mansion/react-native-svg/pull/2016) **Full Changelog**: software-mansion/react-native-svg@v13.8.0...v13.9.0 ### [`v13.8.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.8.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.7.0...v13.8.0) Minor release bringing Fabric support to RN v0.71 🎉 #### What's Changed - feat: update FabricExample to 0.71.0-rc.6 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1962](https://github.com/software-mansion/react-native-svg/pull/1962) - chore: ensure consistent use of `import type` by [@​tido64](https://github.com/tido64) in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1979](https://github.com/software-mansion/react-native-svg/pull/1979) #### New Contributors - [@​tido64](https://github.com/tido64) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1971](https://github.com/software-mansion/react-native-svg/pull/1971) **Full Changelog**: software-mansion/react-native-svg@v13.7.0...v13.8.0 ### [`v13.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.7.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.6.0...v13.7.0) #### What's Changed - Fix windows build issues by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1923](https://github.com/software-mansion/react-native-svg/pull/1923) - fix: fill/stroke setters and implement currentColor on Windows by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1928](https://github.com/software-mansion/react-native-svg/pull/1928) - refactor: remove circular dependency by [@​Fasteel](https://github.com/Fasteel) in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - Include proguard config by [@​heroic](https://github.com/heroic) in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - fix: accept comas in viewbox by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1952](https://github.com/software-mansion/react-native-svg/pull/1952) - Fix nested SVGs in iOS [#​1437](https://github.com/react-native-community/react-native-svg/issues/1437) by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1948](https://github.com/software-mansion/react-native-svg/pull/1948) - fix: restore black as a default color for svgs by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1947](https://github.com/software-mansion/react-native-svg/pull/1947) - feat(windows): add clipPath and touch events by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1933](https://github.com/software-mansion/react-native-svg/pull/1933) - fix: Call onLoad prop in SvgCssUri by [@​mantasio](https://github.com/mantasio) in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) - feat(windows): add example app by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/1937](https://github.com/software-mansion/react-native-svg/pull/1937) #### New Contributors - [@​Fasteel](https://github.com/Fasteel) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1929](https://github.com/software-mansion/react-native-svg/pull/1929) - [@​heroic](https://github.com/heroic) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1842](https://github.com/software-mansion/react-native-svg/pull/1842) - [@​mantasio](https://github.com/mantasio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1927](https://github.com/software-mansion/react-native-svg/pull/1927) **Full Changelog**: software-mansion/react-native-svg@v13.6.0...v13.7.0 ### [`v13.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v13.6.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.5.0...v13.6.0) Minor release fixing some bugs and introducing compatibility with Static View Configs, Bridgeless Mode and maybe some more updated on `Fabric`. #### What's Changed - chore: remove formatting from blame by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1905](https://github.com/software-mansion/react-native-svg/pull/1905) - feat: use codegenNativeComponent to import native views by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1847](https://github.com/software-mansion/react-native-svg/pull/1847) - chore: add react-native-svg banner to README by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) - fix: make svg compile on older versions by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1907](https://github.com/software-mansion/react-native-svg/pull/1907) - chore: update RN versions to 0.70.5 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1910](https://github.com/software-mansion/react-native-svg/pull/1910) - fix: update supported RN version to 0.64 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1912](https://github.com/software-mansion/react-native-svg/pull/1912) - chore: align examples by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1914](https://github.com/software-mansion/react-native-svg/pull/1914) - chore: bump supported RN version for Fabric by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1913](https://github.com/software-mansion/react-native-svg/pull/1913) - feat: use transform parsing code from rn core by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/1918](https://github.com/software-mansion/react-native-svg/pull/1918) #### New Contributors - [@​kacperkapusciak](https://github.com/kacperkapusciak) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/1909](https://github.com/software-mansion/react-native-svg/pull/1909) **Full Changelog**: software-mansion/react-native-svg@v13.5.0...v13.6.0 ### [`v13.5.0`](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v13.4.0...v13.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
note: this is a duplicate for a PR authored by @galkahana that could not be merged due to technical reasons
Summary
we use clickable Svg elements in our app and in order to test it, there is a need for testId / accessibility desc attributes in native elements, so it could be use with tests selectors.
To fix this I added accessiblity Info to all SVG elements (via VirtualView and SvgView).
specifically the following properties of AccessibilityNodeInfo are set:
setBoundsInScreen - This is used by accessibility readers to determine the position and dimensions of an element. For Appium it determines the clickable/visible area of the element.
setVisibleToUser - A boolean flag that determines whether an element is visible at all to the user. For appium it determines whether this elements is visible at all in the tree hierarchy.
setClassName - This one provides a name for the class to be visible in the tree hierarchy. If not set it uses a default android.view.ViewGroup. By setting the class name it's much easier to find your way in the tree. This is not required for a minimal solution for Appium, but it helps a lot.
example with screenshots of before and after the change to demonstrate:
here Im adding accessibilityLabel and testID props to the circles in the group in the example app (examples/G.txs: 24):
and here is how it looks when inspecting the elements:
before the change:
after change:
(notice before the change the ViewGroup does not have children, and with the change it has children with the accessibility and testId atrrs)
Test Plan
Test Plan
To test you can use Appium inspector and appium server gui and see that setting the props makes the relevant props visible, in a similar manner to plain RN views. e.g. "content-description" would be set for "accessibiltyLabel" in android. "testID" would map the "name" in IOS.
For detox or selenuim, in particular in Android, where it is different from Appium, it is possible to write a basic test in detox and run it.
What's required for testing (prerequisites)?
you will want detox and appium setups. and some basic tests.
What are the steps to reproduce (after prerequisites)?
For appium, best is to just view the relevant properties (testID and accessibilityLabel) in Appium desktop.
For detox, running a test successfully will work.
Compatibility
Checklist
README.md
__tests__
folder