Add CI to publish builtin plugins #1648
Conversation
DelevoXDG
changed the title
| name: Publish plugins | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SCARB_REGISTRY_AUTH_TOKEN: ${{ secrets.SCARB_REGISTRY_AUTH_TOKEN }} |
There was a problem hiding this comment.
What token do you think we should keep in our GitHub secrets? Do we want to use some sort of an organization account, or will my personal token do for now? :D
Also, do you think we need any expiration date for it?
There was a problem hiding this comment.
Your personal will do. One year rotation seems alright.
| name: Publish plugins | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SCARB_REGISTRY_AUTH_TOKEN: ${{ secrets.SCARB_REGISTRY_AUTH_TOKEN }} |
There was a problem hiding this comment.
Your personal will do. One year rotation seems alright.
| env: | ||
| SCARB_INIT_TEST_RUNNER: cairo-test | ||
|
|
||
| - name: Check if plugin versions exist in the registry |
There was a problem hiding this comment.
Why do we need to check it here? Can't we just try to publish and let the pipeline fail if it has already been uploaded? (Generally it expect it not to be, right?)
| if: steps.check-plugins.outputs.starknet_exists != 'true' | ||
| run: | | ||
| pushd $HOME/.cache/scarb/registry/std/v${{ steps.scarb-init.outputs.CAIRO_VERSION }}/starknet | ||
| scarb publish --no-verify |
| - name: Publish starknet | ||
| if: steps.check-plugins.outputs.starknet_exists != 'true' | ||
| run: | | ||
| pushd $HOME/.cache/scarb/registry/std/v${{ steps.scarb-init.outputs.CAIRO_VERSION }}/starknet |
There was a problem hiding this comment.
This should read path from Scarb, instead of hardcoding it here.
|
|
||
| - uses: software-mansion/setup-scarb@v1 | ||
| with: | ||
| scarb-version: ${{ github.ref_name }} |
There was a problem hiding this comment.
Won't this be refs/tags/<tag_name>? https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release
Test run: https://github.com/software-mansion/scarb/actions/runs/11365042651/job/31612347755?pr=1649
Closes #1619