Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ios app name resolution on linux #118

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix: ios app name resolution on linux #118

merged 3 commits into from
Sep 20, 2024

Conversation

km1chno
Copy link
Contributor

@km1chno km1chno commented Sep 20, 2024 •
edited
Loading

Why

npx expo prebuild on linux generates ios/ directory without {iOSProjectName}.xcworkspace.

When running npx expo prebuild && ls -al ios | awk -F' ' '{print $NF}' in expo project, the results are:

macos

.gitignore
.xcode.env
.xcode.env.local
Podfile
Podfile.lock
Podfile.properties.json
Pods
build
{iOSProjectName}
{iOSProjectName}.xcodeproj
{iOSProjectName}.xcworkspace

linux

.gitignore
.xcode.env
Podfile
Podfile.properties.json
{iOSProjectName}
{iOSProjectName}.xcodeproj

Solution

Evaluate iOSAppName based on ios/*.xcodeproj instead of ios/*.xcworkspace.

Other changes

Change jest workflow runner from macos-latest to ubuntu-latest.

@km1chno km1chno self-assigned this Sep 20, 2024
@km1chno km1chno marked this pull request as draft September 20, 2024 11:29
@km1chno km1chno marked this pull request as ready for review September 20, 2024 11:59
maciekstosio
maciekstosio approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

@km1chno km1chno merged commit 1770bb4 into main Sep 20, 2024
4 checks passed
@km1chno km1chno deleted the @km1chno/fix-ios-app-name-resolution-on-linux branch September 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciekstosio maciekstosio maciekstosio approved these changes

Assignees

@km1chno km1chno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@km1chno @maciekstosio