feat: add basic integration tests #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
km1chno
commented
Jul 11, 2024
km1chno
commented
Jul 11, 2024
km1chno
commented
Jul 11, 2024
km1chno
commented
Jul 11, 2024
km1chno
changed the title
km1chno
changed the title
km1chno
force-pushed
the
feat-add-integration-tests
branch
from
bf40327 to
647be31
Compare
km1chno
force-pushed
the
feat-add-integration-tests
branch
from
04f34d1 to
2954c0a
Compare
maciekstosio
previously approved these changes
Sep 9, 2024
|
I will merge it after #94 and after regenerating snapshots |
maciekstosio
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2
heavily inspired by https://github.com/roninoss/create-expo-stack/blob/main/cli/__tests__/cli-integration.test.ts
Test projects
rn-setup-ci-yarn-flat(normal repo, non-expo)rn-setup-ci-npm-flat(normal repo, non-expo)rn-setup-ci-yarn-monorepo(monorepo, generated using create-expo-app)rn-setup-ci-npm-monorepo(monorepo, generated using create-expo-app)rn-setup-ci-create-expo-stack(normal repo, generated using create-expo-stack)No EAS Update tests
I created tests for all recipes except EAS Update, since we plan on doing more changes in EAS in the near future, we can add it once it stabilizes.
No interactive tests
I tried to add interactive tests, but it didn't work. TL;DR I guess clack has some abstraction over input events that make stuff like
subprocess.stdin.write('\n') //to simulate enter programaticallynot working.--non-interactiveflagI wanted to at least test action prompts in detox, so I added
--non-interactiveflag that skips thePress enter to continue...prompt. We should add full support for it and document it in the future.What next
expo prebuildandroid/ios app name prompts, we would need some abstraction over it https://github.com/orgs/software-mansion-labs/projects/12/views/1?pane=issue&itemId=77050698--non-interactiveflag properly https://github.com/orgs/software-mansion-labs/projects/12/views/1?pane=issue&itemId=77554964