feat: specify which account is missing/has an invalid signature on signature verification failure #2002
Conversation
|
Just saw there's an official issue for this, so linking this here too: #2001 |
There was a problem hiding this comment.
Awesome!
This code used to, and still does, have bail-out behaviour – it returns upon finding the first bad signature.
Let's go further and make it all-the-way useful. Can you refactor this PR so that it unconditionally verifies all of the signatures, and then logs the addresses of all the failed signers?
|
Sounds good, changed it to aggregate the errors & added another test to check that the aggregation works as expected. Feel free to take another look @steveluscher |
steveluscher
added
the
automerge
|
|
steveluscher
changed the title
steveluscher
changed the title
|
🎉 This PR is included in version 1.88.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
In my experience, an annoying error to get because it doesn't give you the information you really want (which account has the problem) even though it clearly can. This PR fixes this.
Also seems I'm not the only that finds this annoying: https://twitter.com/redacted_noah/status/1742943786299191741