Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change request retry output log to an error log #2038

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jan 13, 2024

When rate limiting errors are hit in the legacy library, an error message is logged via console.log rather than console.error. This means that this error message gets logged to stdout for node apps.. which is very annoying when writing node scripts.

@buffalojoec buffalojoec merged commit 5e43617 into solana-labs:master Jan 15, 2024
6 checks passed
Copy link
Contributor

🎉 This PR is included in version 1.89.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jstarry jstarry deleted the fix-server-error-log-level branch January 16, 2024 00:33
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants