Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Avoid bug in fetch() with non-object reasons thrown with AbortSignal #2325

Closed
steveluscher opened this issue Mar 15, 2024 · 1 comment · Fixed by #2326
Closed

[experimental] Avoid bug in fetch() with non-object reasons thrown with AbortSignal #2325

steveluscher opened this issue Mar 15, 2024 · 1 comment · Fixed by #2326
Labels
bug Something isn't working
Milestone
Release Technolog...

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Mar 15, 2024 •
edited

Overview

The AbortSignal reason can be whatever you want, but there's a bug in undici <6.7.0 that chokes on signal reasons that are not objects. Read all about the fix here: nodejs/undici#2833

We need to make sure that none of our reasons trigger this bug or we're incompatible with undici <6.7.0 and >6.?.?. In my testing this only blows up in Node 21.
@steveluscher steveluscher added the bug Something isn't working label Mar 15, 2024
@steveluscher steveluscher mentioned this issue Mar 15, 2024
Merged
@mergify mergify bot closed this as completed in #2326 Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release Technology Preview 2
1 participant
@steveluscher