fix: Compare public key values not references

[buffalojoec]

Problem

As mentioned in #3118, using == or != to compare two PublicKey objects will compare their references. This means the conditional will only evaluate to be a match if they are the same object. Additionally, if two build targets or versions of @solana/web3.js are being used, these will always be different objects, even if the keys are the same value.

We've encountered the latter issue before, and this appears to be the last place in the legacy library where we still do this conditional without using the PublicKey.equals method.

Summary of Changes

Run a search through the codebase for any public key comparisons using == or != and update them to use PublicKey.equals. There's only one.

Closes #3118

[changeset-bot]

⚠️ No Changeset found

Latest commit: cd6f2f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[steveluscher]

[github-actions]

🎉 This PR is included in version 1.95.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.