Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large (ottersec #6) #33509

Open
samkim-crypto opened this issue Oct 3, 2023 · 0 comments

Comments

@samkim-crypto
Copy link
Contributor

Problem

When gens_capacity becomes too large when generating BulletProofGens, then this could panic due to overflow.

Note: For token2022 application, we only use u64/u128/u256 batched range proofs, which can't panic, but it would be good to fix a potential panic in case range proof is used elsewhere more generally.

Proposed Solution

Introduce a maximum cap on gens_capacity.

@samkim-crypto samkim-crypto changed the title [zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large [zk-token-sdk] Potential overflow when gens_capcity for the bulletproof generators become too large (ottersec #6) Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant