Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

High rate of tvu ingress traffic causes delinquency #8861

Closed
leoluk opened this issue Mar 14, 2020 · 6 comments · Fixed by #8975
Closed

High rate of tvu ingress traffic causes delinquency #8861

leoluk opened this issue Mar 14, 2020 · 6 comments · Fixed by #8975
Assignees
Labels
security Pull requests that address a security vulnerability

Comments

@leoluk
Copy link
Contributor

leoluk commented Mar 14, 2020

A high rate of inbound shreds to the tvu port (~50 kpps) causes validators to fall out of sync with the network and become delinquent.

This how one of the recent TdS networks died (aided the the repair issues at the time that prevented nodes from getting back in sync, so they could be attacked one by one vs. having to target 1/3).

Still works, tested on our TdS node by replaying the same valid shred a lot of times:

image

(you can see where it switches to its own fork and goes delinquent until traffic stops)

@leoluk leoluk changed the title High rate of tvu ingress traffic causes validator to become delinquent High rate of tvu ingress traffic causes delinquency Mar 14, 2020
@mvines
Copy link
Contributor

mvines commented Mar 14, 2020

Do you know if the same is true if the payload is an invalid shred? That would lower the bar for this attack from "anybody who gets enough stake to be in the leader schedule" to "anybody"

@leoluk
Copy link
Contributor Author

leoluk commented Mar 14, 2020

Works with invalid shreds, too. Tried by replaying a SLP shred on TDS, still killed the node.

@leoluk
Copy link
Contributor Author

leoluk commented Mar 14, 2020

I did not investigate how much of that is due to the TVU stalling vs. overloading the host OS.

@sakridge sakridge self-assigned this Mar 16, 2020
@sakridge
Copy link
Contributor

@leoluk can you share the hardware setup you used to produce this?

@leoluk
Copy link
Contributor Author

leoluk commented Mar 17, 2020

16 vCores @ 2.3 GHz (Skylake Xeon), 64G RAM, NVMe disk

@leoluk
Copy link
Contributor Author

leoluk commented Mar 17, 2020

@leoluk leoluk added the security Pull requests that address a security vulnerability label Sep 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants