Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getFees with test #18851

Closed
wants to merge 1 commit into from
Closed

add getFees with test #18851

wants to merge 1 commit into from

Conversation

Arrowana
Copy link
Contributor

Problem

No getFees

Summary of Changes

Add getFees

Fixes #

@mergify mergify bot added the community Community contribution label Jul 22, 2021
@mergify mergify bot requested a review from a team July 22, 2021 23:15
@jstarry jstarry requested a review from oJshua July 22, 2021 23:17
@oJshua
Copy link
Contributor

oJshua commented Jul 23, 2021

@Arrowana This looks great. Could you rename your commit for 7ffe40a to feat: add getFees with test just so we can verify CI passes fully?

@oJshua
Copy link
Contributor

oJshua commented Jul 23, 2021

Thanks again for your contribution on this @Arrowana. I'm just learning that this endpoint is likely set to be deprecated, so we won't be bringing this PR in.

Some more details can be found here (#18875)

@oJshua oJshua closed this Jul 23, 2021
@Arrowana
Copy link
Contributor Author

Arrowana commented Jul 23, 2021 •
edited
Loading

Ok the reason i need this is because:
https://discordapp.com/channels/428295358100013066/517163444747894795/864632440865030174
"For the blockhash that you used, save the associated lastValidBlockHeight. Once the current block height is greater, the transaction is invalid if not yet confirmed"
I want better guarantees on the state of a transaction, where can i get lastValidBlockHeight then, no other json rpc call offers it.

I need a mechanism to guarantee an issued transaction has been dropped.

@Arrowana Arrowana deleted the get-fees-web3js branch July 19, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oJshua oJshua oJshua approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arrowana @oJshua