Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing typescript transitive peer dependency #169

Closed
1 task
rtritto opened this issue Nov 23, 2024 · 0 comments · Fixed by #172
Closed
1 task

Missing typescript transitive peer dependency #169

rtritto opened this issue Nov 23, 2024 · 0 comments · Fixed by #172
Assignees
Labels
bug Something isn't working

Comments

@rtritto
Copy link
Contributor

rtritto commented Nov 23, 2024

Describe the bug

@typescript-eslint/utils is a dependency of eslint-plugin-solid and has typescript peer dependency.
package.json of eslint-plugin-solid must also include typescript peer dependency because it's a transitive peer dependency.

To Reproduce

  • yarn init -y
  • yarn set version berry
  • yarn add -D eslint typescript eslint-plugin-solid
  • (optional) yarn explain peer-requirements and see logs
    pcc27b → ✘ eslint-plugin-solid@npm:0.14.4 [3223e] doesn't provide typescript to @typescript-eslint/utils@npm:8.15.0 [e3d25] and 2 other dependencies
  • (detailed) yarn explain peer-requirements pcc27b and see logs
    eslint-plugin-solid@npm:0.14.4 [3223e]
    └─ @typescript-eslint/utils@npm:8.15.0 [e3d25] (via *)
       └─ @typescript-eslint/typescript-estree@npm:8.15.0 [0f560] (via *)
          └─ ts-api-utils@npm:1.3.0 [37728] (via >=4.2.0)
    
    ✘ Package eslint-plugin-solid@npm:0.14.4 [3223e] does not provide typescript.

Expected behavior

No warning on logs

Environment (please complete the following information):

  • OS: [e.g. Mac OS 11, Windows 10]
  • Node version (node --version): 22.11.0
  • eslint-plugin-solid version (npm list eslint-plugin-solid/yarn why eslint-plugin-solid): 0.14.4
  • eslint version (npm list eslint/yarn why eslint): 9.15.0

Additional context

  • I would be willing to contribute a PR to fix this issue

Workaround

.yarnrc.yml

+packageExtensions:
+  eslint-plugin-solid@*:
+    peerDependencies:
+      typescript: "*"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants