Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with { type: "json" } to package.json import #56

Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Oct 30, 2024

This makes it possible to execute the create-solid package locally with deno:

deno run -A --unstable-bare-node-builtins ./packages/create-solid/src/index.ts

In .js, node can't resolve named imports directly from json either, like deno, it's only bun that supports that directly for .js/.ts

See

Towards

@birkskyum
Copy link
Contributor Author

birkskyum commented Oct 30, 2024

@Tommypop2 , any change you can have a look at this? I'd like to proceed adding the deno as an option in the cli, and this is a prerequisite for that. The with {type: "json"} syntax has been backported to node 18, 20 etc.

@Tommypop2
Copy link
Member

Looks good, thanks!

@Tommypop2 Tommypop2 merged commit fbba4d7 into solidjs-community:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants