Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate information in readme - parcel support can be added #49

Closed
danieltroger opened this issue Jan 3, 2024 · 2 comments · Fixed by #54
Closed

Inaccurate information in readme - parcel support can be added #49

danieltroger opened this issue Jan 3, 2024 · 2 comments · Fixed by #54

Comments

@danieltroger
Copy link

In the readme it states

ParcelJS doesn't support conditional exports yet, which makes ParcelJS load the production build of SolidJS instead of its development build. Solid Refresh requires the SolidJS development build to work.

However, parcel supports package.json#exports since 6+ months back (however behind a flag until they release 3.0.0), see parcel-bundler/parcel#4155 and https://parceljs.org/blog/v2-9-0/#new-resolver

@lxsmnsyc
Copy link
Member

lxsmnsyc commented Jan 3, 2024

I'm not doubting that, but my claim was pretty accurate the last time I made the commit: 21c4df5

Of course at the time of its release there wasn't any config support for it. Funnily enough, I recall some issues in Parcel besides it. Will probably have to test this again for actual confirmation.

@danieltroger
Copy link
Author

Yeah, would be cool with parcel HMR support. Right now we just have full page reloads all the time in our parcel projects.

@lxsmnsyc lxsmnsyc mentioned this issue Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants