Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get styled-system working #148

Closed
praneybehl opened this issue Apr 26, 2020 · 7 comments
Closed

Trying to get styled-system working #148

praneybehl opened this issue Apr 26, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@praneybehl
Copy link
Contributor

praneybehl commented Apr 26, 2020

Trying to get styled-system to work with solid-styled-system(goober) but it seem to be not working:
https://codesandbox.io/s/solid-goober-styled-system-emiq6?file=/index.js

Although, trying with emotion works:
https://codesandbox.io/s/solid-emotion-py2hy?file=/index.js

Any idea why?

@ryansolid
Copy link
Member

Looks like Goober isn't serializing the object passed that way and just setting it to "object". I know it supports top-level object functions. I want to verify it with a different library with Goober like preact and they are in the process of winding up for 2.0.0 release. But I will look at opening up an issue on Goobers repo.

@ryansolid
Copy link
Member

ryansolid commented Apr 27, 2020

Ok confirmed this is functionality they do not have currently. While you can pass in object form top-level it currently isn't supported nested in templates. I've opened up an issue. cristianbote/goober#136

@ryansolid ryansolid added the question Further information is requested label Apr 27, 2020
@ryansolid ryansolid added enhancement New feature or request and removed question Further information is requested labels May 4, 2020
@cristianbote
Copy link

Hey there, pushed a new version 2.0.9 which now interpolates/compiles the objects inside the tagged templates as well. Hopefully this will get it going 👍 if not please let me know so I can address it.

@praneybehl
Copy link
Contributor Author

Hi @cristianbote, thank you for the update.
@ryansolid can we please bump the goober version on the solid-styled-components package?

@ryansolid
Copy link
Member

Sure no problem I can do that tonight.

@ryansolid
Copy link
Member

So happy to close this one. v0.21.1. Enjoy.

Thanks @cristianbote.

@ayoubphy
Copy link

ayoubphy commented Oct 7, 2021

I still can't get styled-system to work, I cheked gobber#136 and I noticed something wierd in the workaround sandbox, the style properties are showing up as an attribute in the html element.

<div class="App"><div color="#fff" bg="tomato" class="go1565677261">Hello CodeSandbox</div><h2>Start editing to see some magic happen!</h2><div color="#fff" bg="tomato" class="go4094543492">Hello Workaround</div></div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants