Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gloo Fed needs to stop using clusterName field in k8s 1.24 #6611

Closed
jenshu opened this issue Jun 23, 2022 · 6 comments
Closed

Gloo Fed needs to stop using clusterName field in k8s 1.24 #6611

jenshu opened this issue Jun 23, 2022 · 6 comments
Assignees
@nfuden
Labels
Area: Gloo Fed Issues related to the Gloo Fed project in solo-projects Type: Bug Something isn't working
Milestone
1.13 rc cut proposed

Comments

@jenshu
Copy link
Contributor

jenshu commented Jun 23, 2022

Gloo Edge Version

1.12.x (beta)

Kubernetes Version

No response

Describe the bug

Currently Gloo Fed uses the metadata.clusterName field to store registered cluster names.
Kubernetes has deprecated the field and changed its name as of 1.24 and will remove it in 1.25

We will need to store the cluster name in a different field.

Steps to reproduce the bug

N/A

Expected Behavior

N/A

Additional Context

No response
@jenshu jenshu added Type: Bug Something isn't working Area: Gloo Fed Issues related to the Gloo Fed project in solo-projects labels Jun 23, 2022
@bcollard
Copy link
Contributor

bcollard commented Sep 2, 2022

linked to solo-io/skv2#362?

@bcollard bcollard mentioned this issue Sep 2, 2022
Closed
@nfuden nfuden added this to the 1.13 rc cut proposed milestone Oct 24, 2022
@Ido-Itz
Copy link

Ido-Itz commented Nov 22, 2022 •
edited

Which gloo-fed resource uses the metadata.clusterName field?

@jenshu
Copy link
Contributor Author

jenshu commented Nov 22, 2022

Which gloo-fed resource uses the metadata.clusterName field?

It's only used in memory to keep track of which resources came from which cluster. It's not written to storage.

@nfuden nfuden self-assigned this Dec 7, 2022
@Ido-Itz
Copy link

Ido-Itz commented Dec 19, 2022

Which gloo-fed resource uses the metadata.clusterName field?

It's only used in memory to keep track of which resources came from which cluster. It's not written to storage.

In this case, it's safe for us to upgrade to Kubernetes 1.24. Am I right?

@jenshu
Copy link
Contributor Author

jenshu commented Dec 19, 2022

Gloo Fed does not yet work on 1.24, i would not upgrade until this is resolved

@jenshu jenshu reopened this Dec 20, 2022
@jenshu
Copy link
Contributor Author

jenshu commented Dec 22, 2022

fix will be available in GlooEE v1.12.41, v1.13.0, and v1.14.0-beta2

@jenshu jenshu closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfuden nfuden

Labels
Area: Gloo Fed Issues related to the Gloo Fed project in solo-projects Type: Bug Something isn't working
Projects
None yet
Milestone
1.13 rc cut proposed
Development

No branches or pull requests
4 participants
@bcollard @Ido-Itz @jenshu @nfuden