Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch status writes to use k8s patch #387

Open
kdorosh opened this issue Oct 4, 2022 · 2 comments
Open

Switch status writes to use k8s patch #387

kdorosh opened this issue Oct 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@kdorosh
Copy link
Contributor

kdorosh commented Oct 4, 2022

similar to solo-io/solo-kit#517

we saw at scale Gloo was being rate limit by k8s writing statuses to resources.

moving to a k8s patch can lower the api calls required, no longer using a read then write call pattern. this drastically improved status reporting at scale

@kdorosh
Copy link
Contributor Author

kdorosh commented Oct 4, 2022

fyi @Sodman @nrjpoddar as part of stability effort for GM

@kdorosh kdorosh added the enhancement New feature or request label Oct 4, 2022
@kdorosh
Copy link
Contributor Author

kdorosh commented Oct 4, 2022

if done right, we can also restrict permissions for the patch to the status subresource, so GM controller no longer needs create permissions (or patch on anything but the subresource) which allows us to better use k8s rbac to protect against a potentially catastrophic bug in GM affecting routing behavior (e.g. race with read/write blowing away updates, if 409 retry logic is buggy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant