Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constraining watched secrets to specific namespaces #399

Closed
jenshu opened this issue Dec 8, 2022 · 0 comments · Fixed by #397
Closed

Allow constraining watched secrets to specific namespaces #399

jenshu opened this issue Dec 8, 2022 · 0 comments · Fixed by #397
Assignees

Comments

@jenshu
Copy link
Contributor

jenshu commented Dec 8, 2022

When we register a cluster, a Secret of type solo.io/kubeconfig is created in the provided namespace on the management cluster to allow access to the remote cluster.

To watch for changes to kubeconfig secrets, we create a ClusterWatcher. Currently, we cannot constrain the namespaces in which to watch secrets, so the clusterWatcher will reconcile secrets from all namespaces. This can cause conflicts if a management cluster has registered multiple remote clusters with the same name but in different namespaces, since we key the managers only by cluster name. To fix this, we should allow watching only secrets from specified namespace(s).

Perhaps a longer term solution might also involve changing how we store cluster names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant