Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring parity between make run-tests and CI commands #450

Open
nikolasmatt opened this issue May 24, 2023 · 0 comments
Open

Bring parity between make run-tests and CI commands #450

nikolasmatt opened this issue May 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nikolasmatt
Copy link
Contributor

Problem

Tests pass in CI but fail using the make run-tests command locally.

CI uses the REMOTE_CLUSTER_CONTEXT=kind-skv2-test-remote PATH="$(pwd)/_output/.bin:$PATH" go test ./... to run tests and all the tests pass, but make run-tests uses a ginkgo command and different tests fail every time.

This is likely because make run-tests randomizes the test execution order and the CI command doesn't.

Desired Outcomes

  • Update the command that CI and/or make use to be the same and include execution order randomization.
  • Make sure make run-tests succeeds when run locally
@nikolasmatt nikolasmatt added the bug Something isn't working label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant