Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryModifier removes non-redundant abstract, final modifiers from nested classes #842

Closed
mches opened this issue Oct 8, 2024 · 2 comments

Comments

@mches
Copy link
Contributor

mches commented Oct 8, 2024

UnnecessaryModifier removes non-redundant abstract, final modifiers from nested classes

e.g.

public interface Parent {
  public static abstract class AbstractClass {}

  public static final class FinalClass extends AbstractClass {}
}

↓↓↓

public interface Parent {
  class AbstractClass {}

  class FinalClass extends AbstractClass {}
}

and

public @interface Parent {
  public static abstract class AbstractClass {}

  public static final class FinalClass extends AbstractClass {}
}

↓↓↓

public @interface Parent {
  class AbstractClass {}

  class FinalClass extends AbstractClass {}
}
mches added a commit to markitect-dev/cleanthat that referenced this issue Oct 8, 2024
mches added a commit to markitect-dev/cleanthat that referenced this issue Oct 8, 2024
mches added a commit to markitect-dev/cleanthat that referenced this issue Oct 8, 2024
mches added a commit to markitect-dev/cleanthat that referenced this issue Oct 8, 2024
mches added a commit to markitect-dev/cleanthat that referenced this issue Oct 8, 2024
@blacelle
Copy link
Member

blacelle commented Oct 8, 2024

Thanks for the report and the fix. This has been released in Cleanthat 1.22 ; it shall be available in m2central within minutes/hours.

@blacelle blacelle closed this as completed Oct 8, 2024
@mches
Copy link
Contributor Author

mches commented Oct 9, 2024

Thanks. I've already put it to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants