From 1bfc9bcca741211abe4754f72d3011dbebea59e5 Mon Sep 17 00:00:00 2001 From: michael_shih Date: Tue, 23 Feb 2021 16:42:06 +0800 Subject: [PATCH] [as4630-54te] Fix LGTM alerts_1. --- .../sonic-platform-modules-accton/as4630-54te/setup.py | 1 - .../as4630-54te/utils/accton_as4630_54te_monitor.py | 4 +++- .../as4630-54te/utils/accton_as4630_54te_util.py | 5 ++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/setup.py b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/setup.py index 2c770b6372a3..78b45368c791 100755 --- a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/setup.py +++ b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/setup.py @@ -1,7 +1,6 @@ #!/usr/bin/env python import os -import sys from setuptools import setup os.listdir diff --git a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_monitor.py b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_monitor.py index 77b27798334d..8c704ac60e86 100755 --- a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_monitor.py +++ b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_monitor.py @@ -20,13 +20,13 @@ # ------------------------------------------------------------------ try: + import os import sys import getopt import logging import logging.config import logging.handlers import time - import commands from as4630_54te.fanutil import FanUtil from as4630_54te.thermalutil import ThermalUtil except ImportError as e: @@ -196,6 +196,8 @@ def manage_fans(self): 'Alarm-Critical for temperature critical is detected, reset DUT') cmd_str = "i2cset -y -f 3 0x60 0x4 0xE4" time.sleep(2) + return_value = os.system(cmd_str) + logging.warning('Fan set: i2cset -y -f 3 0x60 0x4 0xE4, status is %d', return_value) #logging.debug('ori_state=%d, current_state=%d, temp_val=%d\n\n',ori_state, fan_policy_state, temp_val) diff --git a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_util.py b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_util.py index e8514d9652e5..5eee2c3e2c5e 100755 --- a/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_util.py +++ b/platform/broadcom/sonic-platform-modules-accton/as4630-54te/utils/accton_as4630_54te_util.py @@ -160,7 +160,8 @@ if DEBUG: - print 'ARGV :', sys.argv[1:] + print(sys.argv[0]) + print('ARGV : %s' % sys.argv[1:]) def main(): @@ -363,8 +364,6 @@ def device_install(): def device_uninstall(): global FORCE - status, output = log_os_system("ls /sys/bus/i2c/devices/0-0070", 0) - for i in range(0, len(sfp_map)): target = "/sys/bus/i2c/devices/i2c-" + \ str(sfp_map[i]) + "/delete_device"