[202405][FC] Put default counters in init_cfg.json #20555
Merged
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
wen587
approved these changes
Oct 22, 2024
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Nov 13, 2024
|
@stepanblyschak Can you check the issue? Is |
|
@bingwang-ms This change should come together with #20554 and sonic-net/sonic-swss#3326 |
StormLiangMS
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit dbf1baa.
|
@stepanblyschak Can you help confirm if the issue will be addressed if #20554 is merged? Otherwise I tend to revert this PR. |
bingwang-ms
pushed a commit
that referenced
this pull request
Nov 21, 2024
11 tasks
|
@bingwang-ms We're running 202405 with all FC changes together in regression and observe not issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Simplify approach to delaying counters on warm boot and fast boot. Removed FLEX_COUNTER_DELAY_STATUS_FIELD and instead postpone all FC processing to happen after apply view to not delay data plane configuration.
The CONFIG_DB should not be updated in runtime anymore for counters to be delayed.
To address #20302.
Work item tracking
How I did it
Put FC into init_cfg.json
How to verify it
Boot the system, verify counters are enabled.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)