Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFP-Refactor] Modify transceiver dict vendor key name #250

Closed
aravindmani-1 opened this issue Dec 6, 2021 · 0 comments
Closed

[SFP-Refactor] Modify transceiver dict vendor key name #250

aravindmani-1 opened this issue Dec 6, 2021 · 0 comments

Comments

@aravindmani-1
Copy link
Contributor

With earlier SFP refactor, 'hardware_rev' is used in place of 'vendor_rev'.
With new SFP refactor, this issue is fixed. In some platforms, vendor_rev key is not defined in transceiver dictionary.
'hardware_rev' is not mentioned in SFF specs except CMIS.
If sonic-net/sonic-platform-daemons#231 is integrated, xcvrd will crash for the vendors as 'vendor_rev' key is not defined.
All the repository has to change 'hardware_rev' key to 'vendor_rev' key as it'd mislead the EEPROM information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant