Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long term solution for URL regression #101

Closed
kali opened this issue Jan 29, 2020 · 3 comments · Fixed by #104
Closed

Long term solution for URL regression #101

kali opened this issue Jan 29, 2020 · 3 comments · Fixed by #104

Comments

@kali
Copy link
Collaborator

kali commented Jan 29, 2020

see #97

Consider patching url upstream.
@MarcTreySonos
Copy link
Contributor

as the post-release.sh is running cargo update:
https://github.com/snipsco/dinghy/blob/b4500f3b3e9d2939efef9c1878963fa8f0ea6598/post-release.sh#L27

the url regression is back into master #97 (comment)

@Deluvi Deluvi mentioned this issue Feb 13, 2020
Merged
@kali kali closed this as completed in #104 Feb 13, 2020
@kali kali reopened this Feb 13, 2020
@kali
Copy link
Collaborator Author

kali commented Feb 13, 2020

Reopened, we will probably have to un-freeze this version at some point in the future, so we need url to be patched upstream.

@Deluvi
Copy link
Contributor

Deluvi commented Apr 9, 2020

Fixed by #111

@Deluvi Deluvi closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert url lib bump to 2.1.0 sonos/dinghy
3 participants
@kali @Deluvi @MarcTreySonos