Skip to content

Commit

Permalink
Fix Ubuntu 20.04 test runner installation of SDPoker (#218)
Browse files Browse the repository at this point in the history
Explicitly pecify git+https://git@github.com/{user}/{repo}.git to workaround npm "feature" of rewriting GitHub package specs (npm/cli#2610), which applies on GitHub Actions after the Ubuntu 20.04 image 20211129.1 update (actions/runner-images#4625) upgraded to Node v16.13.0 (npm v8.1.0)

Finally, stop using sudo in order to avoid permissions issue on the npm cache (npm/cli#624)
  • Loading branch information
garethsb authored Dec 7, 2021
1 parent 575d8f9 commit 5144d9f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,7 @@ jobs:
pip install -r requirements.txt

# Install SDPoker
if [[ "${{ matrix.os }}" == "windows-latest" || "$EUID" == "0" ]]; then
npm install -g AMWA-TV/sdpoker
else
sudo npm install -g AMWA-TV/sdpoker
fi
npm install -g git+https://git@github.com/AMWA-TV/sdpoker.git
run_python="python"
fi
pip install -r utilities/run-test-suites/gsheetsImport/requirements.txt
Expand Down Expand Up @@ -763,11 +759,7 @@ jobs:
pip install -r requirements.txt

# Install SDPoker
if [[ "${{ matrix.os }}" == "windows-latest" || "$EUID" == "0" ]]; then
npm install -g AMWA-TV/sdpoker
else
sudo npm install -g AMWA-TV/sdpoker
fi
npm install -g git+https://git@github.com/AMWA-TV/sdpoker.git
run_python="python"
fi
pip install -r utilities/run-test-suites/gsheetsImport/requirements.txt
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/src/amwa-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@
pip install -r requirements.txt

# Install SDPoker
if [[ "${{ matrix.os }}" == "windows-latest" || "$EUID" == "0" ]]; then
npm install -g AMWA-TV/sdpoker
else
sudo npm install -g AMWA-TV/sdpoker
fi
npm install -g git+https://git@github.com/AMWA-TV/sdpoker.git
run_python="python"
fi
pip install -r utilities/run-test-suites/gsheetsImport/requirements.txt
Expand Down

0 comments on commit 5144d9f

Please sign in to comment.