Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dice] Ugly SyntaxErrors for invalid die rolls #1189

Closed
dgw opened this issue Apr 23, 2017 · 0 comments
Closed

[dice] Ugly SyntaxErrors for invalid die rolls #1189

dgw opened this issue Apr 23, 2017 · 0 comments
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tweak
Milestone

Comments

@dgw
Copy link
Member

dgw commented Apr 23, 2017

People really like trying to break bots… Several users got in on the fun this weekend, trying to roll dice like 0x1d0x3, 0dNaN, 1d3d4d5, onedone, and variations on that sort of thing.

The dice module, I guess, doesn't catch SyntaxError exceptions. If parsing the given dice expression fails, some generic error ("I'm sorry, you have to give me real dice." or something like that) should get output rather than the likes of Ast.Node 'Call' not implemented.

Probably an easy fix, which I'll get to soon enough if nobody else beats me to it.

@dgw dgw added Low Priority Tweak Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Patches Welcome labels Mar 23, 2018
@dgw dgw added this to the 6.6.0 milestone Mar 26, 2018
@dgw dgw closed this as completed in #1386 Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tweak
Projects
None yet
Development

No branches or pull requests

1 participant