Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining uses of sopel.web in core #1316

Closed
7 of 11 tasks
dgw opened this issue Apr 10, 2018 · 3 comments
Closed
7 of 11 tasks

Remove remaining uses of sopel.web in core #1316

dgw opened this issue Apr 10, 2018 · 3 comments
Assignees
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tracking Tweak
Milestone

Comments

@dgw
Copy link
Member

dgw commented Apr 10, 2018

All remaining core modules that still use sopel.web should be updated to use requests directly instead. I'll be doing this in bits of spare time when I don't feel like working on anything substantial.

Modules I found in my search (and migration status):

@dgw dgw added Low Priority Tweak Tracking Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement labels Apr 10, 2018
@dgw dgw added this to the 6.6.0 milestone Apr 10, 2018
@dgw dgw self-assigned this Apr 10, 2018
@dasu
Copy link
Contributor

dasu commented Apr 16, 2018

isup: web.get is used, but i'm wondering if we should do requests.head instead. Would save on downloading the whole site to get an answer the headers would have provided anyways.

PS: etymology doesn't seem to be working

@dgw
Copy link
Member Author

dgw commented Apr 16, 2018

web didn't have a head method, so switching is totally on the table. (It did and does still, I dunno what file I was reading.)

etymology not working is a separate issue, #1248

@dgw
Copy link
Member Author

dgw commented Jun 5, 2018

Closing this, as everything that was planned has been done. Can be reopened and updated if anything happens with #1318 (or a new tracking issue created for the moved functions).

@dgw dgw closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tracking Tweak
Projects
None yet
Development

No branches or pull requests

2 participants