Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spellcheck: remove to separate package #1642

Closed
4 tasks done
dgw opened this issue Jun 23, 2019 · 1 comment
Closed
4 tasks done

spellcheck: remove to separate package #1642

dgw opened this issue Jun 23, 2019 · 1 comment

Comments

@dgw
Copy link
Member

dgw commented Jun 23, 2019

Despite switching from enchant to aspell (#1164), the spellcheck module can still cause issues with installing Sopel on Windows (#1142). Even on *nix systems, there are system-level package requirements (libraries and dictionary files) that often trip up the installation. It's more than a little absurd for one optional plugin to potentially halt the entire install process for Sopel, when the user might not even want any of the core module set.

I still want to leave most "package-ification" for a later release (see #1291), but I've become convinced over the past few months that removing spellcheck from the base installation package sooner is warranted. I just see way too many complaints about installation problems related to it, and spellcheck is the only core plugin with dependencies that pip can't always install.

So, if anyone wants to be co-maintainer of the soon-to-be-external spellcheck plugin, comment here and/or send me a PM on freenode (I'm also dgw there). When I return from my overseas trip in a week or so, I'll make the repository, add collaborators (if any), and get started on this.


Tasks:

@dgw
Copy link
Member Author

dgw commented Oct 30, 2019

The plugin is now published at https://pypi.org/project/sopel-spellcheck/ (or see the repo).

As PyPI does not have any release of Sopel 7.x available yet, this requires an existing "editable" install of Sopel @ 40162a4 or newer. pip will not be able to satisfy the sopel>=7.0 dependency on its own until we begin publishing alpha/beta/RC versions.

@dgw dgw closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant