Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: command-regexp functions shouldn't be public #1887

Closed
14 tasks done
dgw opened this issue Jun 6, 2020 · 3 comments · Fixed by #1944 or #2141
Closed
14 tasks done

tools: command-regexp functions shouldn't be public #1887

dgw opened this issue Jun 6, 2020 · 3 comments · Fixed by #1944 or #2141
Assignees
Labels
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jun 6, 2020

The major rule-system rework in #1873 is a great excuse to take the get_*_regexp() and get_*_pattern() functions from sopel.tools and either shove them into someplace like sopel.plugins.rules.utils or encapsulate the pattern generation into the different rule object classes.

@Exirel let's come back to this after #1873 is finished.

Full to-deprecate list (for 7.1):

Full to-delete list (for 8.0):

@dgw
Copy link
Member Author

dgw commented Oct 11, 2020

Updating the OP based on discussion in #1944 (comment)

@dgw dgw closed this as completed in #1944 Nov 6, 2020
@dgw
Copy link
Member Author

dgw commented Nov 6, 2020

This wasn't supposed to be auto-closed. Whoops.

@dgw
Copy link
Member Author

dgw commented Feb 23, 2021

The rest of this is for 8.0; reassigning milestone.

@dgw dgw modified the milestones: 7.1.0, 8.0.0 Feb 23, 2021
@dgw dgw linked a pull request Jul 26, 2021 that will close this issue
4 tasks
@dgw dgw closed this as completed in #2141 Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants