trigger: inconsistent sender
for other general messages like QUIT
#2331
Labels
Milestone
sender
for other general messages like QUIT
#2331
This is a follow-up to #2217, which reports an exception case that is technically fixed, but the underlying cause (weird behavior with certain message types) still exists.
Code referenced below sets an intermediate variable to
None
, then populates it based on the arguments to whatever command Sopel received unless that command was QUIT. This leaves some edge cases hanging about, like handling of AWAY on servers withaway-notify
turned on—another command that's just generally sent to any clients that share a channel with the acting user, but isn't associated with any channel or private-message buffer.sopel/sopel/trigger.py
Lines 213 to 225 in 71380df
Making this consistent would be best.
trigger.sender
beingNone
is safer now that #2217 was fixed in #2306, and it's definitely not ideal for the sender to be set toIdentifier("the away message")
on received AWAY commands.The text was updated successfully, but these errors were encountered: