Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wanted: Smarter recent-messages data/detection #2340

Open
dgw opened this issue Aug 8, 2022 · 1 comment
Open

Wanted: Smarter recent-messages data/detection #2340

dgw opened this issue Aug 8, 2022 · 1 comment

Comments

@dgw
Copy link
Member

dgw commented Aug 8, 2022

Spawned from #2320, #2327 tries to make an incremental improvement to the way Sopel keeps track of recent messages. This issue exists to take that even further.

As @Exirel said in #2320 (comment):

Albeit not perfect, the time window has it uses as it prevents some false positive. However, it's not really well done, because it only check if the last message is within that time window, so you could have one message 5s away, and the previous 7 a day old, and it'll still think there is a loop.

The relevant code has changed a little and the exact numbers can be configured now, but the sentiment is still true. We talked about improving the data structure, about limiting it in a smarter way (other than just a line count), and about making the repetition detection itself smarter based on those improvements.

Does this need to block 8.0? No, and I won't assign it to that milestone. We just want to keep this in mind for the following release.

@dgw dgw added the Tweak label Aug 8, 2022
@dgw dgw added this to the 8.1.0 milestone Aug 8, 2022
@dgw
Copy link
Member Author

dgw commented Oct 5, 2023

Came up again today in chat and I was inspired to do a little research. Behold the TimeDeque object: https://stackoverflow.com/a/75972239/5991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants