Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #174 - 메인 뷰 화면 연결 #175

Merged
merged 2 commits into from
Apr 17, 2023
Merged

[Feat] #174 - 메인 뷰 화면 연결 #175

merged 2 commits into from
Apr 17, 2023

Conversation

elesahich
Copy link
Contributor

🌴 PR 요약

메인뷰를 작업했습니다.

🌱 작업한 브랜치

  • feature/connect-scene

🌱 PR Point

모두 체크해 보았어요

📌 참고 사항

그런데 사파리로 넘기는 거라 이게 직접적 리젝 사유가 될수도 있을것 가타요... 이게 아니라면 버튼을 없애야 해요!

📸 동영상

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-04-17.at.21.00.39.mp4

📮 관련 이슈

@elesahich elesahich self-assigned this Apr 17, 2023
lsj8706
lsj8706 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요!!!
화면 전환 되는 거 보니까 이제 드디어 진짜 앱 같아졌네요!!👍

SOPT-iOS/Projects/Features/MainFeature/Sources/MainScene/VC/MainVC.swift
switch (indexPath.section, indexPath.row) {
case (0, _): break
case (1, _):
guard let service = viewModel.mainServiceList[safe: indexPath.item - 1] else { return }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 빼준 것까지 깔끔합니다!!

devxsby
devxsby approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신속하고 ! 정확한 ! 작업 ! 멋쪄요. 💪

L-j-h-c
L-j-h-c approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴다~ 로그인 상태로 웹뷰 전환하는 것은 사파리뷰컨에선 불가능한거죠...?

SOPT-iOS/Projects/Features/AuthFeature/Sources/SignInScene/VC/SignInVC.swift
@@ -195,7 +195,9 @@ extension SignInVC {
)
let output = self.viewModel.transform(from: input, cancelBag: cancelBag)

output.isSignInSuccess.sink { [weak self] isSuccessed in
output.isSignInSuccess
.removeDuplicates()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

0inn
0inn approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~ ~ 👍🏻
연결하니까 멋지네요 . .

@devxsby devxsby mentioned this pull request Apr 17, 2023
Closed
2 tasks
@devxsby devxsby added Feat 새로운 기능 구현 승호 🐶 labels Apr 17, 2023
@elesahich
Copy link
Contributor Author

@L-j-h-c 이게 사파리웹뷰가 세션을 공유하는것 같더라고요! (externalApp이랑 inApp Safari는 안 되고요)

@elesahich elesahich merged commit f890d4e into sopt-makers:develop Apr 17, 2023
@elesahich elesahich deleted the feature/connect-scene branch April 17, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@0inn 0inn 0inn approved these changes

Assignees

@elesahich elesahich

Labels
Feat 새로운 기능 구현 size/M 승호 🐶
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 메인 뷰 화면 연결
5 participants
@elesahich @0inn @L-j-h-c @lsj8706 @devxsby