Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Poke UI Component : Chip, BottomSheet MessageView, NotificationListContentView 작성 #316

Merged

Conversation

elesahich
Copy link
Contributor

@elesahich elesahich commented Dec 3, 2023

🌴 PR 요약

Poke에서 사용하는 UI Component인 Chip과 BottomSheet MessageView, NotificationListContentView를 작성했어요

🌱 작업한 브랜치

  • feature/#poke-design-componet-1

🌱 PR Point

  • 컨텐츠의 width height를 고정하지 말고
  • 양 옆 컨텐츠의 relation을 고려해서 쓰면 되어요
  • UIGestureRecognizer Publisher가 없어서 하나 데려왔어요 유용하게 쓰거든요~ (제가)

📌 참고 사항

📸 스크린샷

미디어 설명
RPReplay_Final1701586449.MP4
바텀싯에 끼워서 쓰면 되어요
여러곳에서 끼워서 쓰면 되어요
메인과 알림리스트에서 잘 쓸거에요

📮 관련 이슈

@elesahich elesahich added Feat 새로운 기능 구현 승호 🐶 labels Dec 3, 2023
@elesahich elesahich self-assigned this Dec 3, 2023
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿구구구구국굿
바텀시트 기욥네요 ~~~

@elesahich
Copy link
Contributor Author

elesahich commented Dec 3, 2023

아니 여기는 바텀싯트가 업는건데.... #312 에 있는데.... @devxsby

Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!! Chip이랑 Message 뷰 잘 쓸게요! ㅎㅎ

import Combine
import UIKit

public struct GesturePublisher: Publisher {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커스텀 퍼블리셔!!

@elesahich elesahich changed the title [Feature] Poke UI Component : Chip, BottomSheet MessageView 작성 [Feature] Poke UI Component : Chip, BottomSheet MessageView, NotificationListContentView 작성 Dec 3, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Dec 3, 2023
Comment on lines +65 to +70
case tap(UITapGestureRecognizer = .init())
case swipe(UISwipeGestureRecognizer = .init())
case longPress(UILongPressGestureRecognizer = .init())
case pan(UIPanGestureRecognizer = .init())
case pinch(UIPinchGestureRecognizer = .init())
case edge(UIScreenEdgePanGestureRecognizer = .init())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 진짜 유용하겠네요 👍🏻👍🏻

@elesahich elesahich force-pushed the feature/poke-design-components-1 branch from 5fae325 to 1b82ca2 Compare December 4, 2023 14:35
@elesahich elesahich merged commit 278dd3f into sopt-makers:develop Dec 4, 2023
@elesahich elesahich deleted the feature/poke-design-components-1 branch December 4, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/XL 승호 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 컴포넌트 만들기 : 칩 / 바텀싯 컨텐츠 / 노티리스트메인
4 participants