Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #360 - 솝탬프 개선 #365

Merged
merged 13 commits into from
Apr 10, 2024

Conversation

lsj8706
Copy link
Member

@lsj8706 lsj8706 commented Apr 5, 2024

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  1. 파트별 랭킹 기능 추가
  2. 34기 랭킹과 파트별 랭킹 버튼 분리

📌 참고 사항

  • 요즘 너무 바빠서 급하게 만드느라 코드 퀄리티가 정말 별로입니다... 시간나면 뜯어 고치겠습니다.
  • PR 크기랑 커밋 크기도 너무 커서 리뷰하기 힘들 것 같네요..
  • 더미데이터가 부족해서 파트 내부 개별 랭킹 뷰는 확인이 어려운데 서버 개발자분들이 추가해줄 것 같습니다.

📸 스크린샷

기능 스크린샷
랭킹 Simulator Screen Recording - iPhone 15 Pro - 2024-04-06 at 01 00 20

📮 관련 이슈

@lsj8706 lsj8706 added Feat 새로운 기능 구현 세진🤝🏻 labels Apr 5, 2024
@lsj8706 lsj8706 self-assigned this Apr 5, 2024
Copy link

height bot commented Apr 5, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@ffalswo2 ffalswo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@lsj8706 lsj8706 merged commit 9dea61a into sopt-makers:develop Apr 10, 2024
@lsj8706 lsj8706 deleted the feat/#360-솝탬프-개선 branch April 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/XXL 세진🤝🏻
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 솝탬프 개선
2 participants