Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Stamp 34기 대응 : missionDate를 같이 올릴수 있도록, 라우팅 영역 변경, 닉네임 변경 제한 #366

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

elesahich
Copy link
Contributor

🌴 PR 요약

제목과 같아요 : 1) missionDate를 솝탬프에 같이 올릴수 있도록, ListView > DetailView 라우팅 영역 변경, 닉네임 변경 제한

🌱 작업한 브랜치

  • feature/stamp-for-34-gen

🌱 PR Point

  1. 이게 2줄로 줄이다 보니까 그-냥 천줄이 넘어 버리는데 그렇게 큰 건 아니에요

missionDate를 stamp에 같이 올릴수 있도록 변경

  • presignedUrl을 사용하도록 변경했어요
  • s3 주소에 multipart upload 할때 자꾸 moya에서 이상한 HTTPHeader를 넣길래 alamofire를 사용했어요. (변경해도 아무 상관 없어요)
  • UI도 조금 바뀌었지만 큰 변경은 아니여요
RPReplay_Final1712592567.MP4

Stamp ListView > DetailView로 가는 클릭 영역 변경

닉네임 변경 제한

설정 > 솝탬프 닉네임 변경 ListItem이 제거되었어요

📌 참고 사항

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

  • Resolved: #

@elesahich elesahich added Feat 새로운 기능 구현 승호 🐶 labels Apr 8, 2024
@elesahich elesahich self-assigned this Apr 8, 2024
Copy link

height bot commented Apr 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!👍🏼

Copy link
Contributor

@ffalswo2 ffalswo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

Comment on lines 80 to 81
import Combine
import UIKit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요고 위에 import되어있는데 또 들어갔어요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거했어요~~!

@elesahich elesahich merged commit 41891a2 into sopt-makers:develop Apr 10, 2024
@elesahich elesahich deleted the feature/stamp-for-34-gen branch April 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/XXL 승호 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants