Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] MDS Font Util 생성 및 Poke에 일부 적용 #373

Conversation

elesahich
Copy link
Contributor

@elesahich elesahich commented Jun 2, 2024

🌴 PR 요약

MDS Font syntax를 작성하고 일부에 적용했어요!

🌱 작업한 브랜치

  • feature/#mds~

🌱 PR Point

✅ Guide

  • .text 는 없어져야 해요
  • 각 클래스의 .attributedText prop을 이용해야 해요 (UILabel.attributedText ~)
    $0.attributedText = I18N.Poke.Onboarding.description.applyMDSFont(
      mdsFont: .body3,
      color: DSKitAsset.Colors.gray30.color
    )

이렇게 적용해서 쓰면 됩니다!

✅ TODO

  1. MDS Font는 letterSpacing도 있는데 이건 figma에서 나타내는 방법이랑 iOS의 방법이 달라요
  2. 부연 설명 : kern value는 절댓값. / figma : 비율 표기
  3. 따라서 이건 수작업이 필요해요. 두개를 띄워놓고 정교한 눈을 가지고 맞추는 작업이 필요함요!

📌 참고 사항

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

  • Resolved: #

@elesahich elesahich added the Feat 새로운 기능 구현 label Jun 2, 2024
@elesahich elesahich self-assigned this Jun 2, 2024
Copy link

height bot commented Jun 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏼

@elesahich elesahich force-pushed the improvement/mds-font-construction-structure branch from a36c01e to 4fb7c6c Compare June 6, 2024 01:19
@elesahich elesahich merged commit 1bad2b5 into sopt-makers:develop Jun 6, 2024
@elesahich elesahich deleted the improvement/mds-font-construction-structure branch June 6, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants