From d8a7f2ee3805d31f68bd0c5931aa19bb26e5bf4f Mon Sep 17 00:00:00 2001 From: Dongmin Date: Sat, 8 Jun 2024 23:34:31 +0900 Subject: [PATCH] feat #725: code clear --- .../friend/detail/FriendListDetailBottomSheetFragment.kt | 7 ++++--- .../poke/friend/summary/FriendListSummaryActivity.kt | 7 ++++--- .../sopt/official/feature/poke/main/PokeMainActivity.kt | 7 ++++--- .../feature/poke/notification/PokeNotificationActivity.kt | 7 ++++--- 4 files changed, 16 insertions(+), 12 deletions(-) diff --git a/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt b/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt index 539223f6a..a8a764a30 100644 --- a/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt +++ b/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt @@ -139,9 +139,10 @@ class FriendListDetailBottomSheetFragment : BottomSheetDialogFragment() { anonymousFriend?.let { tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName) tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name) - it.profileImage.takeIf { image -> - image.isNotEmpty() - }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } } + imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) { + transformations(CircleCropTransformation()) + } + imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage) } diff --git a/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt b/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt index 042b6c542..f7d9bdc2f 100644 --- a/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt +++ b/feature/poke/src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt @@ -130,9 +130,10 @@ class FriendListSummaryActivity : AppCompatActivity() { anonymousFriend?.let { tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName) tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name) - it.profileImage.takeIf { image -> - image.isNotEmpty() - }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } } + imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) { + transformations(CircleCropTransformation()) + } + imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage) } diff --git a/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt b/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt index b29391d93..5e69d1291 100644 --- a/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt +++ b/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt @@ -164,9 +164,10 @@ class PokeMainActivity : AppCompatActivity() { anonymousFriend?.let { tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName) tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name) - it.profileImage.takeIf { image -> - image.isNotEmpty() - }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } } + imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) { + transformations(CircleCropTransformation()) + } + imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage) } diff --git a/feature/poke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt b/feature/poke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt index a6557258e..e404aa4bb 100644 --- a/feature/poke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt +++ b/feature/poke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt @@ -132,9 +132,10 @@ class PokeNotificationActivity : AppCompatActivity() { anonymousFriend?.let { tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName) tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name) - it.profileImage.takeIf { image -> - image.isNotEmpty() - }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } } + imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) { + transformations(CircleCropTransformation()) + } + imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage) }