Recovery pallet added and configured #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vovac12
approved these changes
Jun 1, 2023
sorabot
requested review from
Alexey-N-Chernyshov,
wer1st,
bragov4ik,
pakrentos,
vovac12 and
N1ghtStorm
wer1st
reviewed
Jul 28, 2023
| @@ -249,6 +251,7 @@ std = [ | |||
| "pallet-offences/std", | |||
| "pallet-preimage/std", | |||
| "pallet-randomness-collective-flip/std", | |||
| "pallet-recovery/std", | |||
There was a problem hiding this comment.
Probably we need to add "pallet-recovery/try-runtime" below if it has this feature
There was a problem hiding this comment.
I think it works without it
There was a problem hiding this comment.
Of course it works, but it is necessary for cases when we use try-runtime
It is |
bragov4ik
reviewed
Feb 1, 2024
|
|
||
| impl pallet_recovery::Config for Runtime { | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type WeightInfo = pallet_recovery::weights::SubstrateWeight<Runtime>; |
There was a problem hiding this comment.
I think we're supposed to benchmark it ourselves (with our reference hardware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.