Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOPS-2746 Add sonar, dojo #903

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

C4tWithShell
Copy link
Contributor

  1. Set up sonar
  2. Set up dojo
  3. Fixed problem with coverage, change to lcov format

housekeeping/coverage.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@Alexey-N-Chernyshov Alexey-N-Chernyshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't have an access to Sonar, please ensure that developers can access it.
  2. I was assured that DefectDojo has been already enabled: https://defectdojo.tachi.soramitsu.co.jp/product/90. At least there is the report. And I don't understand the process of Defect Dojo. We have a bunch of findings and it seems that they are ignored. I don't know who is responsible for this tool. And please, check that developers are granted an access.

Update: I got access to SonarQube.

Copy link
Contributor

@Alexey-N-Chernyshov Alexey-N-Chernyshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. I see the flag is set in SonarQube but I don't see any summary report on gh.

  2. WARN: sonar.plugins.downloadOnlyRequired is false, so ALL available plugins will be downloaded Downloading, installing and running all the plugins for SonarQube takes time, we can enable only that we need.

  3. target dir is analyzed, but should be ignored. Probably it is fixed in https://github.com/soramitsu/jenkins-library/pull/568 for SonarQube. The same issue for DefectDojo.

@C4tWithShell
Copy link
Contributor Author

image

  1. I see the flag is set in SonarQube but I don't see any summary report on gh.
  2. WARN: sonar.plugins.downloadOnlyRequired is false, so ALL available plugins will be downloaded Downloading, installing and running all the plugins for SonarQube takes time, we can enable only that we need.
  3. target dir is analyzed, but should be ignored. Probably it is fixed in Update sonar.groovy - do not scan target soramitsu/jenkins-library#568 for SonarQube. The same issue for DefectDojo.
  1. Yes, there was an error within validation process. I fixed it
  2. It's a new feature, we enabled it
  3. Excluded

Copy link
Contributor

@Alexey-N-Chernyshov Alexey-N-Chernyshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar stage in Jenkins passed while it failed actually. I see errors in Jenkins logs and a new report is missing in SonarQube. Please, make sure Sonar generates and uploads the report. I think Jenkins should fail the job in case of failure, so we can discover the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants