-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOPS-2746 Add sonar, dojo #903
base: develop
Are you sure you want to change the base?
Conversation
C4tWithShell
commented
Feb 13, 2024
- Set up sonar
- Set up dojo
- Fixed problem with coverage, change to lcov format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an access to Sonar, please ensure that developers can access it.- I was assured that DefectDojo has been already enabled: https://defectdojo.tachi.soramitsu.co.jp/product/90. At least there is the report. And I don't understand the process of Defect Dojo. We have a bunch of findings and it seems that they are ignored. I don't know who is responsible for this tool. And please, check that developers are granted an access.
Update: I got access to SonarQube.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I see the flag is set in SonarQube but I don't see any summary report on gh.
-
WARN: sonar.plugins.downloadOnlyRequired is false, so ALL available plugins will be downloaded
Downloading, installing and running all the plugins for SonarQube takes time, we can enable only that we need. -
target
dir is analyzed, but should be ignored. Probably it is fixed in https://github.com/soramitsu/jenkins-library/pull/568 for SonarQube. The same issue for DefectDojo.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonar stage in Jenkins passed while it failed actually. I see errors in Jenkins logs and a new report is missing in SonarQube. Please, make sure Sonar generates and uploads the report. I think Jenkins should fail the job in case of failure, so we can discover the problem.