Prevent example from failing on unmerged PRs #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent users from experiencing sorenlouv#127 when simply following the README example.
sorenlouv
reviewed
Jul 10, 2024
| @@ -14,6 +14,7 @@ on: | |||
| jobs: | |||
| backport: | |||
| name: Backport PR | |||
| if: github.event.pull_request.merged == true && !(contains(github.event.pull_request.labels.*.name, 'backport')) | |||
There was a problem hiding this comment.
It looks like the workflow will only be triggered when the PR is merged and does NOT contain the backport label. Should it be when it's merged and DOES contain the label?
There was a problem hiding this comment.
No - backport is the default label the tool assigns to backport PRs for which we don't want to run the tool again (e.g. no backport of the backport)
There was a problem hiding this comment.
Ah, I misunderstood. That makes sense.
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent users from experiencing #127 when simply following the README example.