Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning #2

Closed
IzzySoft opened this issue Dec 28, 2023 · 16 comments
Closed

versioning #2

IzzySoft opened this issue Dec 28, 2023 · 16 comments

Comments

@IzzySoft
Copy link
Contributor

Please remember to increase versionCode with each new release. This is used by Android internally to tell versions apart and decide whether to accept an APK as update. You currently list 3 releases here, yet the latest identifies as

package: name='com.sosauce.cutecalc' versionCode='1' versionName='1.1.0'

Being the 3rd release, versionCode should at least be 3 at this point.

Thanks in advance for taking care!

@sosauce
Copy link
Owner

sosauce commented Dec 28, 2023

Hi ! Thanks for the feedback 😭 This went right through my radars lol. But now worries ! Should be fixed in version 1.2.0, wich is avaible to download right now !

@IzzySoft
Copy link
Contributor Author

Cool, thanks! Then this one will be updated properly, wonderful!

@sosauce sosauce closed this as completed Dec 29, 2023
@IzzySoft
Copy link
Contributor Author

Looks like it didn't work out:

Binary files /web/ftp/repo/fdroid/repo/com.sosauce.cutecalc_1.apk and /web/ftp/repo/fdroid/repo/com.sosauce.cutecalc_1.2.1.apk differ

which means v1.2.1 still has versionCode: 1. And so will the next release, unless you update this 😉

    defaultConfig {
        applicationId = "com.sosauce.cutecalc"
        minSdk = 24
        targetSdk = 34
        versionCode = 1
        versionName = "1.2.0"

@sosauce
Copy link
Owner

sosauce commented Dec 29, 2023

Oof, my bad, didn't know I had to change that, releasing a fix ASAP

@sosauce
Copy link
Owner

sosauce commented Dec 29, 2023

I updated it, should be good. Do you need an APK the modification or not ?

@IzzySoft
Copy link
Contributor Author

If the next release has it fixed, it should be fine. Just remember to increase it with every release. Also strange that versionName states 1.2.0, while the last release says 1.2.1 – and the APK indeed has 1.2.1. Now I'm confused. Where do you set the "real version"?

@sosauce
Copy link
Owner

sosauce commented Dec 30, 2023

Sorry 😭 This is my first steps in Android dev, so i'm having a hard time with all that. But don't worry version 1.3.0 should have it all correctly :)

@IzzySoft
Copy link
Contributor Author

No worries! I'm not even an Android developer at all, so you're ahead of me there 🙈 Looking forward to the next update then 😃

@sosauce sosauce reopened this Dec 30, 2023
@sosauce
Copy link
Owner

sosauce commented Dec 30, 2023

Update 1.3.0 avaible rn ! I changed the versionCode so should be all good ! also reduced app size by 2, if it can help ;)

@IzzySoft
Copy link
Contributor Author

Thanks, that worked out fine now! 😃 And yes, reducing the size is always a good thing, thanks!

Last question: would you like a PR with the app's metadata (description, graphics) in Fastlane format, so you can control how your app is presented? You're welcome to use my Fastlane Cheat Sheet as reference. It's basically just placing the corresponding text and graphic files into a directory structure, so no rocket science. Fastlane has established as quasi-standard for this.

@sosauce
Copy link
Owner

sosauce commented Dec 30, 2023

I'd be please to do that ! On on vacation right now without my laptop (Github mobile ykyk) So i'll see if I can do it on my phone, if not, it will be done after a come back (Jan 8) !

@IzzySoft
Copy link
Contributor Author

Great! And no need to hurry things. First I need to make that PR – only after that it's for you to act. Basically, if you're happy with what you see, you can simply merge it (then I'd update the config here to check it whenever a new version of your app is pulled) – and adjust it whenever you have time and think it could use some improvements.

I'll prepare the PR then and leave some guiding notes with its opening comment, so you can easily find them.

@sosauce
Copy link
Owner

sosauce commented Dec 30, 2023

Oh okay ! Tell me when it's my turn ;)

@IzzySoft
Copy link
Contributor Author

As I wrote: You can merge right away – which is the signal for me to enable it here. Then at any point you find time for it, you can improve it – e.g. expand the description, add more screenshots, add a featureGraphic, per-release changelogs if you wish… All at your own schedule.

@sosauce
Copy link
Owner

sosauce commented Dec 31, 2023

Ohhh okay, I merged itt

@IzzySoft
Copy link
Contributor Author

Enabled it here. Now, everything else can be done whenever you decide 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants