-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versioning #2
Comments
Hi ! Thanks for the feedback 😭 This went right through my radars lol. But now worries ! Should be fixed in version 1.2.0, wich is avaible to download right now ! |
Cool, thanks! Then this one will be updated properly, wonderful! |
Looks like it didn't work out:
which means v1.2.1 still has defaultConfig {
applicationId = "com.sosauce.cutecalc"
minSdk = 24
targetSdk = 34
versionCode = 1
versionName = "1.2.0" |
Oof, my bad, didn't know I had to change that, releasing a fix ASAP |
I updated it, should be good. Do you need an APK the modification or not ? |
If the next release has it fixed, it should be fine. Just remember to increase it with every release. Also strange that |
Sorry 😭 This is my first steps in Android dev, so i'm having a hard time with all that. But don't worry version 1.3.0 should have it all correctly :) |
No worries! I'm not even an Android developer at all, so you're ahead of me there 🙈 Looking forward to the next update then 😃 |
Update 1.3.0 avaible rn ! I changed the |
Thanks, that worked out fine now! 😃 And yes, reducing the size is always a good thing, thanks! Last question: would you like a PR with the app's metadata (description, graphics) in Fastlane format, so you can control how your app is presented? You're welcome to use my Fastlane Cheat Sheet as reference. It's basically just placing the corresponding text and graphic files into a directory structure, so no rocket science. Fastlane has established as quasi-standard for this. |
I'd be please to do that ! On on vacation right now without my laptop (Github mobile ykyk) So i'll see if I can do it on my phone, if not, it will be done after a come back (Jan 8) ! |
Great! And no need to hurry things. First I need to make that PR – only after that it's for you to act. Basically, if you're happy with what you see, you can simply merge it (then I'd update the config here to check it whenever a new version of your app is pulled) – and adjust it whenever you have time and think it could use some improvements. I'll prepare the PR then and leave some guiding notes with its opening comment, so you can easily find them. |
Oh okay ! Tell me when it's my turn ;) |
As I wrote: You can merge right away – which is the signal for me to enable it here. Then at any point you find time for it, you can improve it – e.g. expand the description, add more screenshots, add a featureGraphic, per-release changelogs if you wish… All at your own schedule. |
Ohhh okay, I merged itt |
Enabled it here. Now, everything else can be done whenever you decide 😃 |
Please remember to increase
versionCode
with each new release. This is used by Android internally to tell versions apart and decide whether to accept an APK as update. You currently list 3 releases here, yet the latest identifies asBeing the 3rd release,
versionCode
should at least be3
at this point.Thanks in advance for taking care!
The text was updated successfully, but these errors were encountered: