-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove use of deprecated np.int #14
Conversation
I thought the recommended change is |
And just to see for myself:
|
I would agree that perhaps In other places (Annie, I believe) I wondered whether it should be Also, the case is clear for |
Ska/Numpy/Numpy.py
Outdated
@@ -71,7 +71,7 @@ def match(recarray, filters): | |||
except TypeError: | |||
pass | |||
|
|||
matches = np.ones(len(recarray), dtype=np.bool) | |||
matches = np.ones(len(recarray), dtype=np.bool_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be bool
.
Description
This PR makes tiny changes to remove uses of a few deprecated dtypes (sot/skare3#753)
Testing
Fixes #