-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test #7
Conversation
javierggt
commented
Dec 26, 2019
- Refactor code to move tests into a submodule.
- Pep8/flake8
This PR is only two commits. It is easier to see the changes separately, because the second one is pep8/flake8. |
NOTE: I don't mind merging before/after the scm_version PR (#6). They are conflicting changes, but they are simple changes, so I can do it either way. |
This was not passing tests locally because Also, the What we really should be doing is just deprecating this package completely and moving remaining bits of functionality into |
About removing this package, I just checked and it does get used in a lot of places. Probably not worth the effort, though we could port all functionality to |
I have reviewed this and tested and it all looks good to me now, so merging. |